Re: [patch 2/2] Speed up JIT support

[Paul Pluzhnikov <ppluzhnikov@google.com>]

On Fri, Feb 4, 2011 at 12:17 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
>
> From what I can tell, the cache is never invalidated.  But, if
> objfile_relocate was called, then I think the cache ought to be
> invalidated, or the addresses relocated.

Right.

> Maybe the cache could point to the symbols themselves.  I think that
> would fix the problem and be both safe and efficient.

Ah, that also nicely takes care of the problematic use of -1 as invalid
core address -- we *know* that 0 and -1 are *not* valid symbol values.

Two birds with one stone :-)

> Paul>  create_exception_master_breakpoint (void)
> Paul>  {
> Paul>    struct objfile *objfile;
> Paul> +  const char *const func_name = "_Unwind_DebugHook";
>
> Paul>    ALL_OBJFILES (objfile)
> Paul>      {
>
> I don't really know why the other functions loop over ALL_PSPACES but
> this one does not.  It is my fault, seeing as I wrote this... but I
> still don't understand.

I didn't understand that either :-(

Thanks,
-- 
Paul Pluzhnikov