From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13714 invoked by alias); 4 Feb 2011 20:33:12 -0000 Received: (qmail 13706 invoked by uid 22791); 4 Feb 2011 20:33:12 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Feb 2011 20:33:05 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id p14KX2XH028962 for ; Fri, 4 Feb 2011 12:33:03 -0800 Received: from qyk12 (qyk12.prod.google.com [10.241.83.140]) by wpaz1.hot.corp.google.com with ESMTP id p14KWISd029793 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NOT) for ; Fri, 4 Feb 2011 12:33:01 -0800 Received: by qyk12 with SMTP id 12so2308448qyk.19 for ; Fri, 04 Feb 2011 12:33:01 -0800 (PST) Received: by 10.229.245.14 with SMTP id ls14mr8952328qcb.19.1296851581299; Fri, 04 Feb 2011 12:33:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.87.162 with HTTP; Fri, 4 Feb 2011 12:32:31 -0800 (PST) In-Reply-To: References: <20110203214614.5FD74190A4E@elbrus2.mtv.corp.google.com> From: Paul Pluzhnikov Date: Fri, 04 Feb 2011 20:33:00 -0000 Message-ID: Subject: Re: [patch 2/2] Speed up JIT support To: Tom Tromey Cc: gdb-patches@sourceware.org, pedro@codesourcery.com, vegorov@chromium.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00097.txt.bz2 On Fri, Feb 4, 2011 at 12:17 PM, Tom Tromey wrote: >>>>>> "Paul" =3D=3D Paul Pluzhnikov writes: > > From what I can tell, the cache is never invalidated. =A0But, if > objfile_relocate was called, then I think the cache ought to be > invalidated, or the addresses relocated. Right. > Maybe the cache could point to the symbols themselves. =A0I think that > would fix the problem and be both safe and efficient. Ah, that also nicely takes care of the problematic use of -1 as invalid core address -- we *know* that 0 and -1 are *not* valid symbol values. Two birds with one stone :-) > Paul> =A0create_exception_master_breakpoint (void) > Paul> =A0{ > Paul> =A0 =A0struct objfile *objfile; > Paul> + =A0const char *const func_name =3D "_Unwind_DebugHook"; > > Paul> =A0 =A0ALL_OBJFILES (objfile) > Paul> =A0 =A0 =A0{ > > I don't really know why the other functions loop over ALL_PSPACES but > this one does not. =A0It is my fault, seeing as I wrote this... but I > still don't understand. I didn't understand that either :-( Thanks, --=20 Paul Pluzhnikov