From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org, pedro@codesourcery.com, vegorov@chromium.org
Subject: Re: [patch 2/2] Speed up JIT support
Date: Fri, 04 Feb 2011 20:17:00 -0000 [thread overview]
Message-ID: <m339o38shg.fsf@fleche.redhat.com> (raw)
In-Reply-To: <AANLkTimcuse=gw-9BQe6sts2qDv3MeDEWtYbr1VEg5JS@mail.gmail.com> (Paul Pluzhnikov's message of "Thu, 3 Feb 2011 13:58:06 -0800")
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Paul> 2010-02-03 Paul Pluzhnikov <ppluzhnikov@google.com>
Paul> * breakpoint.c (longjmp_names): New variable.
Paul> (struct breakpoint_objfile_data): New type.
Paul> (breakpoint_objfile_key): New variable.
Paul> (get_breakpoint_objfile_data): New function.
Paul> (create_overlay_event_breakpoint): Adjust.
Paul> (create_longjmp_master_breakpoint): Adjust.
Paul> (create_std_terminate_master_breakpoint): Adjust.
Paul> (create_exception_master_breakpoint): Adjust.
Paul> (_initialize_breakpoint): Adjust.
From what I can tell, the cache is never invalidated. But, if
objfile_relocate was called, then I think the cache ought to be
invalidated, or the addresses relocated.
Maybe the cache could point to the symbols themselves. I think that
would fix the problem and be both safe and efficient.
Paul> create_exception_master_breakpoint (void)
Paul> {
Paul> struct objfile *objfile;
Paul> + const char *const func_name = "_Unwind_DebugHook";
Paul> ALL_OBJFILES (objfile)
Paul> {
I don't really know why the other functions loop over ALL_PSPACES but
this one does not. It is my fault, seeing as I wrote this... but I
still don't understand.
Tom
next prev parent reply other threads:[~2011-02-04 20:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 21:46 [patch 1/2] " Paul Pluzhnikov
2011-02-03 21:58 ` [patch 2/2] " Paul Pluzhnikov
2011-02-04 18:58 ` Pedro Alves
2011-02-04 20:17 ` Tom Tromey [this message]
2011-02-04 20:33 ` Paul Pluzhnikov
2011-02-05 0:26 ` Paul Pluzhnikov
2011-02-07 15:31 ` Tom Tromey
2011-02-15 21:56 ` Paul Pluzhnikov
2011-02-04 18:28 ` [patch 1/2] " Pedro Alves
2011-02-04 20:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m339o38shg.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=ppluzhnikov@google.com \
--cc=vegorov@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox