From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30255 invoked by alias); 7 Feb 2011 15:31:31 -0000 Received: (qmail 30245 invoked by uid 22791); 7 Feb 2011 15:31:30 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Feb 2011 15:31:25 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p17FVBr7013214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Feb 2011 10:31:12 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p17FVBqN014473; Mon, 7 Feb 2011 10:31:11 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p17FVAJL019047; Mon, 7 Feb 2011 10:31:10 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 3C380378326; Mon, 7 Feb 2011 08:31:10 -0700 (MST) From: Tom Tromey To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org, pedro@codesourcery.com, vegorov@chromium.org Subject: Re: [patch 2/2] Speed up JIT support References: <20110203214614.5FD74190A4E@elbrus2.mtv.corp.google.com> Date: Mon, 07 Feb 2011 15:31:00 -0000 In-Reply-To: (Paul Pluzhnikov's message of "Fri, 4 Feb 2011 16:26:13 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00157.txt.bz2 >>>>> "Paul" == Paul Pluzhnikov writes: Paul> Here is the updated patch (applies on top of the [1/2] cosmetic patch). Paul> Re-tested on linux/x86_64, no regressions. Thanks for doing this. Just some nits, nothing serious. Paul> +/* Per-objfile data private to breakpoint.c */ Period at the end of the comment. Paul> + /* minimal symbol for "_ovly_debug_event" (if any) */ Paul> + struct minimal_symbol *overlay_msym; Comments should start with an upper case character and end with a period. There are a few instances of this. Paul> + Paul> +static int Paul> +msym_not_found_p (const struct minimal_symbol *msym) This function needs an introductory comment. This is ok with these things fixed. Tom