From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 10/12] entryval: @entry values even for references
Date: Tue, 19 Jul 2011 16:20:00 -0000 [thread overview]
Message-ID: <m339i25l02.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20110718202224.GK30496@host1.jankratochvil.net> (Jan Kratochvil's message of "Mon, 18 Jul 2011 22:22:24 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> + CORE_ADDR deref_val_int;
Jan> + if (VALUE_LVAL (original_value) == lval_computed)
Jan> + {
Jan> + const struct lval_funcs *funcs;
Jan> +
Jan> + funcs = value_computed_funcs (original_value);
Jan> + if (funcs->indirect)
Jan> + {
Jan> + struct value *result = funcs->indirect (original_value);
Jan> +
Jan> + if (result)
Jan> + {
Jan> + common_val_print (result, stream, recurse,
Jan> + options, current_language);
Jan> + return 0;
Jan> + }
Jan> + }
Jan> + }
This code is repeated a few times. I think it should go into a new
function.
Jan> +struct value *
Jan> +entry_data_value_indirect (struct value *value)
Jan> +{
I think this should be static.
Jan> +static struct lval_funcs entry_data_value_funcs =
const
Tom
next prev parent reply other threads:[~2011-07-19 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 20:26 Jan Kratochvil
2011-07-19 1:19 ` Daniel Jacobowitz
2011-07-29 15:55 ` Jan Kratochvil
2011-07-19 16:20 ` Tom Tromey [this message]
2011-07-29 15:31 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m339i25l02.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox