From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 10/12] entryval: @entry values even for references
Date: Fri, 29 Jul 2011 15:31:00 -0000 [thread overview]
Message-ID: <20110729152915.GC14528@host1.jankratochvil.net> (raw)
In-Reply-To: <m339i25l02.fsf@fleche.redhat.com>
On Tue, 19 Jul 2011 17:49:01 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
>
> Jan> + if (VALUE_LVAL (original_value) == lval_computed)
[...]
>
> This code is repeated a few times. I think it should go into a new
> function.
done.
> I think this should be static.
+
> const
done, done.
It will be in a new patchset resubmit.
Thanks,
Jan
prev parent reply other threads:[~2011-07-29 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 20:26 Jan Kratochvil
2011-07-19 1:19 ` Daniel Jacobowitz
2011-07-29 15:55 ` Jan Kratochvil
2011-07-19 16:20 ` Tom Tromey
2011-07-29 15:31 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729152915.GC14528@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox