From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82709-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26749 invoked by alias); 29 Jul 2011 15:29:37 -0000
Received: (qmail 26733 invoked by uid 22791); 29 Jul 2011 15:29:36 -0000
X-SWARE-Spam-Status: No, hits=-7.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Jul 2011 15:29:19 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6TFTJUn009837	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 29 Jul 2011 11:29:19 -0400
Received: from host1.jankratochvil.net (ovpn-116-20.ams2.redhat.com [10.36.116.20])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p6TFTGMZ029002	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);	Fri, 29 Jul 2011 11:29:18 -0400
Received: from host1.jankratochvil.net (localhost [127.0.0.1])	by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p6TFTFZc014620;	Fri, 29 Jul 2011 17:29:15 +0200
Received: (from jkratoch@localhost)	by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p6TFTF1h014619;	Fri, 29 Jul 2011 17:29:15 +0200
Date: Fri, 29 Jul 2011 15:31:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 10/12] entryval: @entry values even for references
Message-ID: <20110729152915.GC14528@host1.jankratochvil.net>
References: <20110718202224.GK30496@host1.jankratochvil.net> <m339i25l02.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m339i25l02.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00804.txt.bz2

On Tue, 19 Jul 2011 17:49:01 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> +	  if (VALUE_LVAL (original_value) == lval_computed)
[...]
> 
> This code is repeated a few times.  I think it should go into a new
> function.

done.

> I think this should be static.
+ 
> const

done, done.


It will be in a new patchset resubmit.


Thanks,
Jan