From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26634 invoked by alias); 19 Jul 2011 15:49:23 -0000 Received: (qmail 26625 invoked by uid 22791); 19 Jul 2011 15:49:22 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Jul 2011 15:49:03 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6JFn30q023798 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Jul 2011 11:49:03 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p6JFn2pW010558; Tue, 19 Jul 2011 11:49:03 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p6JFn1Qf005940; Tue, 19 Jul 2011 11:49:02 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch 10/12] entryval: @entry values even for references References: <20110718202224.GK30496@host1.jankratochvil.net> Date: Tue, 19 Jul 2011 16:20:00 -0000 In-Reply-To: <20110718202224.GK30496@host1.jankratochvil.net> (Jan Kratochvil's message of "Mon, 18 Jul 2011 22:22:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00471.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> + CORE_ADDR deref_val_int; Jan> + if (VALUE_LVAL (original_value) == lval_computed) Jan> + { Jan> + const struct lval_funcs *funcs; Jan> + Jan> + funcs = value_computed_funcs (original_value); Jan> + if (funcs->indirect) Jan> + { Jan> + struct value *result = funcs->indirect (original_value); Jan> + Jan> + if (result) Jan> + { Jan> + common_val_print (result, stream, recurse, Jan> + options, current_language); Jan> + return 0; Jan> + } Jan> + } Jan> + } This code is repeated a few times. I think it should go into a new function. Jan> +struct value * Jan> +entry_data_value_indirect (struct value *value) Jan> +{ I think this should be static. Jan> +static struct lval_funcs entry_data_value_funcs = const Tom