From: Tom Tromey <tromey@redhat.com>
To: Jonas Maebe <jonas.maebe@elis.ugent.be>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Set calling convention of methods
Date: Fri, 10 Apr 2009 17:34:00 -0000 [thread overview]
Message-ID: <m31vs0s9da.fsf@fleche.redhat.com> (raw)
In-Reply-To: <B8DEF338-C0F0-40A5-B4B8-D24DC56BFA0E@elis.ugent.be> (Jonas Maebe's message of "Mon\, 6 Apr 2009 21\:51\:00 +0200")
>>>>> "Jonas" == Jonas Maebe <jonas.maebe@elis.ugent.be> writes:
Jonas> In attachment is my patch to set the calling convention for methods.
Do you have a copyright assignment on file?
Jonas> Since the calling convention cannot be defined using stabs, I've
Jonas> hardcoded "0" there (which means that nothing changes compared to the
Jonas> past). Maybe that should rather be some constant? If so, where should
Jonas> it be defined?
Yeah, this is a bit gross. AFAICT the calling convention field only
takes values from dwarf. So, I suppose the question is how you plan
to use this information in later patches. If you check the calling
convention in general code then I suppose we will need some generic
set of values here.
Other than this issue, this looks reasonable to me.
Tom
next prev parent reply other threads:[~2009-04-10 17:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 19:51 Jonas Maebe
2009-04-10 17:34 ` Tom Tromey [this message]
2009-04-20 8:40 ` Jonas Maebe
2009-04-20 18:27 ` Tom Tromey
2009-04-22 17:45 ` Jonas Maebe
2009-04-22 19:22 ` Tom Tromey
2009-04-22 22:16 ` Mark Kettenis
2009-06-04 8:23 ` Jonas Maebe
2009-06-04 18:19 ` Tom Tromey
2009-06-10 20:44 ` Jonas Maebe
2009-06-18 21:45 ` Fwd: " Jonas Maebe
2009-09-30 0:02 ` Joel Brobecker
2009-09-30 11:18 ` Jonas Maebe
2009-09-30 14:54 ` Jonas Maebe
2009-09-30 15:22 ` Mark Kettenis
2009-09-30 16:25 ` Joel Brobecker
2009-10-01 9:18 ` Jonas Maebe
2009-10-01 22:04 ` Joel Brobecker
2009-10-02 9:21 ` Mark Kettenis
2009-09-30 16:10 ` Joel Brobecker
2009-09-30 17:36 ` Joel Brobecker
2009-09-30 16:47 ` Tom Tromey
2009-09-30 17:32 ` Joel Brobecker
2009-09-30 17:35 ` Tom Tromey
2009-10-01 9:21 ` Jonas Maebe
2009-11-03 9:43 ` Jonas Maebe
2009-11-03 14:19 ` Joel Brobecker
2009-07-06 20:50 ` Jonas Maebe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31vs0s9da.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jonas.maebe@elis.ugent.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox