Re: [patch] Set calling convention of methods

Jonas Maebe
2009-04-22T17:45:39Z

On 20 Apr 2009, at 20:25, Tom Tromey wrote:

> "dwarf2.h" is not included in many places in gdb, and not by any
> header. So, assuming your uses of this field will end up in truly
> generic code, I think the thing to do is introduce a new enum, and
> then translate values in the DWARF reader. It is tempting to simply
> reuse the DWARF enum internally, but I think that goes against the GDB
> style.

Ok, I can adapt my patch to clean that up. I'd prefer my i386 Borland
fastcall patch to be committed first though, since changing this
calling convention stuff would also affect that patch. Is that
possible given my current in-progress state as far as the copyright
assignment process is concerned? If so, Mark, could you tell me
whether anything should still be changed in the last version I sent you?

Thanks,

Jonas