Re: [patch] Set calling convention of methods

Jonas Maebe
2009-04-20T08:40:05Z

Sorry for the late reply, I was on holidays.

On 10 Apr 2009, at 19:32, Tom Tromey wrote:

>>>>>> "Jonas" == Jonas Maebe <jonas.maebe@elis.ugent.be> writes:
>
> Jonas> In attachment is my patch to set the calling convention for
> methods.
>
> Do you have a copyright assignment on file?

Not yet. I'm in the final stage of getting the waiver from my employer
to send it to FSF though.

> Jonas> Since the calling convention cannot be defined using stabs,
> I've
> Jonas> hardcoded "0" there (which means that nothing changes
> compared to the
> Jonas> past). Maybe that should rather be some constant? If so,
> where should
> Jonas> it be defined?
>
> Yeah, this is a bit gross. AFAICT the calling convention field only
> takes values from dwarf. So, I suppose the question is how you plan
> to use this information in later patches. If you check the calling
> convention in general code then I suppose we will need some generic
> set of values here.

It is already used in general code (well, in non-DWARF-specific code),
see the use of DW_CC_GNU_renesas_sh in sh-tdep.c

> Other than this issue, this looks reasonable to me.

Thanks.

Jonas