[patch] [ppc64] testsuite: break-interp.exp [Re: info files' Entry point on ppc64]

[patch] [ppc64] testsuite: break-interp.exp [Re: info files' Entry point on ppc64]

[Jan Kratochvil]

On Wed, 08 Sep 2010 18:36:55 +0200, Edjunior Barbosa Machado wrote:
>         Entry point: 0x251c11e0
> break *0x251c11e0
> Program received signal SIGSEGV, Segmentation fault.
> 0x7d821008251b0a90 in ?? ()

OK, thanks for the bugreport, fix attached.

OTOH still both ppc64->ppc32 and ppc64->ppc64 produce a lot of FAILs which
I do not see obvious (such as some `seen displacement message as ZERO' which
should have 0 displacement as being prelinked); I can check them later.


Regards,
Jan


gdb/testsuite/
2010-09-09  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/break-interp.exp (reach): Permit leading . for ppc64.
	(test_ld) <powerpc64-*>: New.

--- a/gdb/testsuite/gdb.base/break-interp.exp
+++ b/gdb/testsuite/gdb.base/break-interp.exp
@@ -136,10 +136,10 @@ proc reach {func command displacement} {
 		}
 		exp_continue
 	    }
-	    -re "Breakpoint \[0-9\]+, $func \\(.*\\) at .*:\[0-9\]+\r\n.*$gdb_prompt $" {
+	    -re "Breakpoint \[0-9\]+, \\.?$func \\(.*\\) at .*:\[0-9\]+\r\n.*$gdb_prompt $" {
 		pass $test
 	    }
-	    -re "Breakpoint \[0-9\]+, \[0-9xa-f\]+ in $func \\(\\).*\r\n$gdb_prompt $" {
+	    -re "Breakpoint \[0-9\]+, \[0-9xa-f\]+ in \\.?$func \\(\\).*\r\n$gdb_prompt $" {
 		pass $test
 	    }
 	}
@@ -399,6 +399,17 @@ proc test_ld {file ifmain trynosym displacement} {
 		pass $test
 	    }
 	}
+	# `info sym' cannot be tested for .opd as the binary may not have
+	# symbols.
+	if [istarget powerpc64-*] {
+	    set test "convert entry point"
+	    gdb_test_multiple "p *(void(*)(void) *) 0x$entrynohex" $test {
+		-re " =( \\(\[^0-9\]*\\))? 0x(\[0-9a-f\]+)( < \[^\r\n\]*)?\r\n$gdb_prompt $" {
+		    set entrynohex $expect_out(2,string)
+		    pass $test
+		}
+	    }
+	}
 	if {$entrynohex != ""} {
 	    gdb_test "break *0x$entrynohex" "" "break at entry point"
 	    gdb_test "continue" "\r\nBreakpoint \[0-9\]+, 0x0*$entrynohex in .*" "entry point reached"

Re: [patch] [ppc64] testsuite: break-interp.exp [Re: info files' Entry point on ppc64]

[Edjunior Barbosa Machado]

On 09/09/2010 11:05 AM, Jan Kratochvil wrote:
> On Wed, 08 Sep 2010 18:36:55 +0200, Edjunior Barbosa Machado wrote:
>>          Entry point: 0x251c11e0
>> break *0x251c11e0
>> Program received signal SIGSEGV, Segmentation fault.
>> 0x7d821008251b0a90 in ?? ()
>
> OK, thanks for the bugreport, fix attached.
>
> OTOH still both ppc64->ppc32 and ppc64->ppc64 produce a lot of FAILs which
> I do not see obvious (such as some `seen displacement message as ZERO' which
> should have 0 displacement as being prelinked); I can check them later.
>
Hi Jan,

thanks for the patch, but it seems it doesn't work properly when testing 32-bit gdb in a 64-bit environment. Using is_lp64_target should avoid this issue.

Thanks,
--
Edjunior Barbosa Machado
IBM Linux Technology Center




gdb/testsuite/

2010-09-10  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>



	* gdb.base/break-interp.exp: add is_lp64_target to check 64bit target



--- a/gdb/testsuite/gdb.base/break-interp.exp
+++ b/gdb/testsuite/gdb.base/break-interp.exp
@@ -401,7 +401,7 @@ proc test_ld {file ifmain trynosym displacement} {
  	}
  	# `info sym' cannot be tested for .opd as the binary may not have
  	# symbols.
-	if [istarget powerpc64-*] {
+	if {[istarget powerpc64-*] && [is_lp64_target]} {
  	    set test "convert entry point"
  	    gdb_test_multiple "p *(void(*)(void) *) 0x$entrynohex" $test {
  		-re " =( \\(\[^0-9\]*\\))? 0x(\[0-9a-f\]+)( < \[^\r\n\]*)?\r\n$gdb_prompt $" {

Re: [patch] [ppc64] testsuite: break-interp.exp

[Jan Kratochvil]

On Fri, 10 Sep 2010 16:54:52 +0200, Edjunior Barbosa Machado wrote:
> thanks for the patch, but it seems it doesn't work properly when testing
> 32-bit gdb in a 64-bit environment. Using is_lp64_target should avoid this
> issue.

Checkd-in as obvious.

Adjusted the ChangeLog entry.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2010-09/msg00077.html

--- src/gdb/testsuite/ChangeLog	2010/09/09 20:00:48	1.2443
+++ src/gdb/testsuite/ChangeLog	2010/09/10 20:29:25	1.2444
@@ -1,3 +1,8 @@
+2010-09-10  Edjunior Barbosa Machado  <emachado@linux.vnet.ibm.com>
+
+	* gdb.base/break-interp.exp (test_ld) <istarget powerpc64-*>: Add
+	is_lp64_target to check 64bit target.
+
 2010-09-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* gdb.base/break-interp.exp (reach): Permit leading . for ppc64.
--- src/gdb/testsuite/gdb.base/break-interp.exp	2010/09/09 20:00:49	1.19
+++ src/gdb/testsuite/gdb.base/break-interp.exp	2010/09/10 20:29:25	1.20
@@ -401,7 +401,7 @@
 	}
 	# `info sym' cannot be tested for .opd as the binary may not have
 	# symbols.
-	if [istarget powerpc64-*] {
+	if {[istarget powerpc64-*] && [is_lp64_target]} {
 	    set test "convert entry point"
 	    gdb_test_multiple "p *(void(*)(void) *) 0x$entrynohex" $test {
 		-re " =( \\(\[^0-9\]*\\))? 0x(\[0-9a-f\]+)( < \[^\r\n\]*)?\r\n$gdb_prompt $" {

Re: [patch] [ppc64] testsuite: break-interp.exp [Re: info files' Entry point on ppc64]

[Tom Tromey]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> OK, thanks for the bugreport, fix attached.

Jan> 2010-09-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	* gdb.base/break-interp.exp (reach): Permit leading . for ppc64.
Jan> 	(test_ld) <powerpc64-*>: New.

This is ok.

Tom

Re: [patch] [ppc64] testsuite: break-interp.exp [Re: info files' Entry point on ppc64]

[Jan Kratochvil]

On Thu, 09 Sep 2010 21:56:32 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> 2010-09-09  Jan Kratochvil  <jan.kratochvil@redhat.com>
> Jan> 	* gdb.base/break-interp.exp (reach): Permit leading . for ppc64.
> Jan> 	(test_ld) <powerpc64-*>: New.
> 
> This is ok.

Checked-in:
	http://sourceware.org/ml/gdb-cvs/2010-09/msg00070.html


Thanks,
Jan