From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25774 invoked by alias); 10 Sep 2010 20:30:37 -0000 Received: (qmail 25766 invoked by uid 22791); 10 Sep 2010 20:30:36 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Sep 2010 20:30:31 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKUTLC032613 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Sep 2010 16:30:29 -0400 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8AKURPU004615 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Sep 2010 16:30:28 -0400 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id o8AKUQUf026063; Fri, 10 Sep 2010 22:30:26 +0200 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id o8AKUPU2026062; Fri, 10 Sep 2010 22:30:25 +0200 Date: Sat, 11 Sep 2010 16:01:00 -0000 From: Jan Kratochvil To: Edjunior Barbosa Machado Cc: gdb-patches@sourceware.org Subject: Re: [patch] [ppc64] testsuite: break-interp.exp Message-ID: <20100910203025.GA25009@host1.dyn.jankratochvil.net> References: <4C87BBA7.7090008@linux.vnet.ibm.com> <20100909140513.GA20677@host1.dyn.jankratochvil.net> <4C8A46BC.7080502@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4C8A46BC.7080502@linux.vnet.ibm.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00235.txt.bz2 On Fri, 10 Sep 2010 16:54:52 +0200, Edjunior Barbosa Machado wrote: > thanks for the patch, but it seems it doesn't work properly when testing > 32-bit gdb in a 64-bit environment. Using is_lp64_target should avoid this > issue. Checkd-in as obvious. Adjusted the ChangeLog entry. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-09/msg00077.html --- src/gdb/testsuite/ChangeLog 2010/09/09 20:00:48 1.2443 +++ src/gdb/testsuite/ChangeLog 2010/09/10 20:29:25 1.2444 @@ -1,3 +1,8 @@ +2010-09-10 Edjunior Barbosa Machado + + * gdb.base/break-interp.exp (test_ld) : Add + is_lp64_target to check 64bit target. + 2010-09-09 Jan Kratochvil * gdb.base/break-interp.exp (reach): Permit leading . for ppc64. --- src/gdb/testsuite/gdb.base/break-interp.exp 2010/09/09 20:00:49 1.19 +++ src/gdb/testsuite/gdb.base/break-interp.exp 2010/09/10 20:29:25 1.20 @@ -401,7 +401,7 @@ } # `info sym' cannot be tested for .opd as the binary may not have # symbols. - if [istarget powerpc64-*] { + if {[istarget powerpc64-*] && [is_lp64_target]} { set test "convert entry point" gdb_test_multiple "p *(void(*)(void) *) 0x$entrynohex" $test { -re " =( \\(\[^0-9\]*\\))? 0x(\[0-9a-f\]+)( < \[^\r\n\]*)?\r\n$gdb_prompt $" {