From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] [ppc64] testsuite: break-interp.exp
Date: Sat, 11 Sep 2010 16:01:00 -0000 [thread overview]
Message-ID: <20100910203025.GA25009@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <4C8A46BC.7080502@linux.vnet.ibm.com>
On Fri, 10 Sep 2010 16:54:52 +0200, Edjunior Barbosa Machado wrote:
> thanks for the patch, but it seems it doesn't work properly when testing
> 32-bit gdb in a 64-bit environment. Using is_lp64_target should avoid this
> issue.
Checkd-in as obvious.
Adjusted the ChangeLog entry.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2010-09/msg00077.html
--- src/gdb/testsuite/ChangeLog 2010/09/09 20:00:48 1.2443
+++ src/gdb/testsuite/ChangeLog 2010/09/10 20:29:25 1.2444
@@ -1,3 +1,8 @@
+2010-09-10 Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
+
+ * gdb.base/break-interp.exp (test_ld) <istarget powerpc64-*>: Add
+ is_lp64_target to check 64bit target.
+
2010-09-09 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/break-interp.exp (reach): Permit leading . for ppc64.
--- src/gdb/testsuite/gdb.base/break-interp.exp 2010/09/09 20:00:49 1.19
+++ src/gdb/testsuite/gdb.base/break-interp.exp 2010/09/10 20:29:25 1.20
@@ -401,7 +401,7 @@
}
# `info sym' cannot be tested for .opd as the binary may not have
# symbols.
- if [istarget powerpc64-*] {
+ if {[istarget powerpc64-*] && [is_lp64_target]} {
set test "convert entry point"
gdb_test_multiple "p *(void(*)(void) *) 0x$entrynohex" $test {
-re " =( \\(\[^0-9\]*\\))? 0x(\[0-9a-f\]+)( < \[^\r\n\]*)?\r\n$gdb_prompt $" {
next prev parent reply other threads:[~2010-09-10 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C87BBA7.7090008@linux.vnet.ibm.com>
2010-09-09 15:27 ` [patch] [ppc64] testsuite: break-interp.exp [Re: info files' Entry point on ppc64] Jan Kratochvil
2010-09-10 15:45 ` Edjunior Barbosa Machado
2010-09-11 16:01 ` Jan Kratochvil [this message]
[not found] ` <20100909140513.GA20677__33509.653612464$1284041144$gmane$org@host1.dyn.jankratochvil.net>
2010-09-09 20:32 ` Tom Tromey
2010-09-09 21:33 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100910203025.GA25009@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox