FYI: final fix for PR 8399

FYI: final fix for PR 8399

[Tom Tromey]

I am checking this in.

While looking into PR 11803, I ran across a kfail for PR 8399.  This bug
was mostly fixed by earlier changes, but one final odd failure remained:
when we ran across an unrecognized frame base expression, we would throw
an error instead of falling back to disassembly.

Built and regtested on x86-64 (compile farm).

Tom

2010-09-14  Tom Tromey  <tromey@redhat.com>

	PR symtab/8399:
	* dwarf2loc.c (locexpr_describe_location_piece): Don't call error
	for unrecognized frame base expression.

2010-09-14  Tom Tromey  <tromey@redhat.com>

	PR symtab/8399:
	* gdb.threads/tls.exp: Remove kfail.  Update expected output.

Index: dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.97
diff -u -r1.97 dwarf2loc.c
--- dwarf2loc.c	12 Aug 2010 19:55:38 -0000	1.97
+++ dwarf2loc.c	14 Sep 2010 19:37:26 -0000
@@ -1940,7 +1940,7 @@
       struct symbol *framefunc;
       int frame_reg = 0;
       LONGEST frame_offset;
-      const gdb_byte *base_data, *new_data;
+      const gdb_byte *base_data, *new_data, *save_data = data;
       size_t base_size;
       LONGEST base_offset = 0;
 
@@ -1984,10 +1984,7 @@
 	{
 	  /* We don't know what to do with the frame base expression,
 	     so we can't trace this variable; give up.  */
-	  error (_("Cannot describe location of symbol \"%s\"; "
-		   "DWARF 2 encoding not handled, "
-		   "first opcode in base data is 0x%x."),
-		 SYMBOL_PRINT_NAME (symbol), base_data[0]);
+	  return save_data;
 	}
 
       regno = gdbarch_dwarf2_reg_to_regnum (gdbarch, frame_reg);
Index: testsuite/gdb.threads/tls.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/tls.exp,v
retrieving revision 1.13
diff -u -r1.13 tls.exp
--- testsuite/gdb.threads/tls.exp	14 Sep 2010 19:08:30 -0000	1.13
+++ testsuite/gdb.threads/tls.exp	14 Sep 2010 19:37:28 -0000
@@ -284,8 +284,8 @@
 gdb_test "info address a_global" \
 	".*a_global.*static storage at address.*" "info address a_global"
 
-setup_kfail "gdb/1294" "*-*-*"
-gdb_test "info address me" ".*me.*is a variable at offset.*" "info address me"
+gdb_test "info address me" ".*me.*is a complex DWARF expression:.*" \
+    "info address me"
 
 
 # Test LOC_UNRESOLVED references resolving for `extern' TLS variables.

Re: FYI: final fix for PR 8399

[Andreas Schwab]

Tom Tromey <tromey@redhat.com> writes:

> Index: testsuite/gdb.threads/tls.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/tls.exp,v
> retrieving revision 1.13
> diff -u -r1.13 tls.exp
> --- testsuite/gdb.threads/tls.exp	14 Sep 2010 19:08:30 -0000	1.13
> +++ testsuite/gdb.threads/tls.exp	14 Sep 2010 19:37:28 -0000
> @@ -284,8 +284,8 @@
>  gdb_test "info address a_global" \
>  	".*a_global.*static storage at address.*" "info address a_global"
>  
> -setup_kfail "gdb/1294" "*-*-*"
> -gdb_test "info address me" ".*me.*is a variable at offset.*" "info address me"
> +gdb_test "info address me" ".*me.*is a complex DWARF expression:.*" \
> +    "info address me"

That does not work.

info address me
Symbol "me" is a variable at frame base reg $r31 offset 48+-36.
(gdb) FAIL: gdb.threads/tls.exp: info address me

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: FYI: final fix for PR 8399

[Andreas Schwab]

Checked in as obvious.

Andreas.

2011-01-09  Andreas Schwab  <schwab@linux-m68k.org>

	* gdb.threads/tls.exp ("info address me"): Fix expected output.

--- testsuite/gdb.threads/tls.exp.~1.17.~	2011-01-02 20:43:00.000000000 +0100
+++ testsuite/gdb.threads/tls.exp	2011-01-09 15:57:06.000000000 +0100
@@ -284,7 +284,7 @@ runto spin
 gdb_test "info address a_global" \
 	".*a_global.*static storage at address.*" "info address a_global"
 
-gdb_test "info address me" ".*me.*is a complex DWARF expression:.*" \
+gdb_test "info address me" ".*me.*is a (complex DWARF expression:|variable).*" \
     "info address me"
 
 

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: FYI: final fix for PR 8399

[Tom Tromey]

Andreas> Checked in as obvious.

Andreas> 2011-01-09  Andreas Schwab  <schwab@linux-m68k.org>
Andreas> 	* gdb.threads/tls.exp ("info address me"): Fix expected output.

Thank you.

Tom