From: Tom Tromey <tromey@redhat.com>
To: gdb-patches@sourceware.org
Subject: FYI: final fix for PR 8399
Date: Tue, 14 Sep 2010 21:21:00 -0000 [thread overview]
Message-ID: <m3d3sg6rno.fsf@fleche.redhat.com> (raw)
I am checking this in.
While looking into PR 11803, I ran across a kfail for PR 8399. This bug
was mostly fixed by earlier changes, but one final odd failure remained:
when we ran across an unrecognized frame base expression, we would throw
an error instead of falling back to disassembly.
Built and regtested on x86-64 (compile farm).
Tom
2010-09-14 Tom Tromey <tromey@redhat.com>
PR symtab/8399:
* dwarf2loc.c (locexpr_describe_location_piece): Don't call error
for unrecognized frame base expression.
2010-09-14 Tom Tromey <tromey@redhat.com>
PR symtab/8399:
* gdb.threads/tls.exp: Remove kfail. Update expected output.
Index: dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.97
diff -u -r1.97 dwarf2loc.c
--- dwarf2loc.c 12 Aug 2010 19:55:38 -0000 1.97
+++ dwarf2loc.c 14 Sep 2010 19:37:26 -0000
@@ -1940,7 +1940,7 @@
struct symbol *framefunc;
int frame_reg = 0;
LONGEST frame_offset;
- const gdb_byte *base_data, *new_data;
+ const gdb_byte *base_data, *new_data, *save_data = data;
size_t base_size;
LONGEST base_offset = 0;
@@ -1984,10 +1984,7 @@
{
/* We don't know what to do with the frame base expression,
so we can't trace this variable; give up. */
- error (_("Cannot describe location of symbol \"%s\"; "
- "DWARF 2 encoding not handled, "
- "first opcode in base data is 0x%x."),
- SYMBOL_PRINT_NAME (symbol), base_data[0]);
+ return save_data;
}
regno = gdbarch_dwarf2_reg_to_regnum (gdbarch, frame_reg);
Index: testsuite/gdb.threads/tls.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/tls.exp,v
retrieving revision 1.13
diff -u -r1.13 tls.exp
--- testsuite/gdb.threads/tls.exp 14 Sep 2010 19:08:30 -0000 1.13
+++ testsuite/gdb.threads/tls.exp 14 Sep 2010 19:37:28 -0000
@@ -284,8 +284,8 @@
gdb_test "info address a_global" \
".*a_global.*static storage at address.*" "info address a_global"
-setup_kfail "gdb/1294" "*-*-*"
-gdb_test "info address me" ".*me.*is a variable at offset.*" "info address me"
+gdb_test "info address me" ".*me.*is a complex DWARF expression:.*" \
+ "info address me"
# Test LOC_UNRESOLVED references resolving for `extern' TLS variables.
next reply other threads:[~2010-09-14 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 21:21 Tom Tromey [this message]
2010-12-27 5:08 ` Andreas Schwab
2011-01-09 15:23 ` Andreas Schwab
2011-01-10 20:40 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3d3sg6rno.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox