From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8310 invoked by alias); 14 Sep 2010 19:39:49 -0000 Received: (qmail 8300 invoked by uid 22791); 14 Sep 2010 19:39:48 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Sep 2010 19:39:42 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8EJdfmF024205 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 Sep 2010 15:39:41 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8EJdeqO024134; Tue, 14 Sep 2010 15:39:40 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8EJddbu007519; Tue, 14 Sep 2010 15:39:40 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 6140B3784BE; Tue, 14 Sep 2010 13:39:39 -0600 (MDT) From: Tom Tromey To: gdb-patches@sourceware.org Subject: FYI: final fix for PR 8399 Date: Tue, 14 Sep 2010 21:21:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00274.txt.bz2 I am checking this in. While looking into PR 11803, I ran across a kfail for PR 8399. This bug was mostly fixed by earlier changes, but one final odd failure remained: when we ran across an unrecognized frame base expression, we would throw an error instead of falling back to disassembly. Built and regtested on x86-64 (compile farm). Tom 2010-09-14 Tom Tromey PR symtab/8399: * dwarf2loc.c (locexpr_describe_location_piece): Don't call error for unrecognized frame base expression. 2010-09-14 Tom Tromey PR symtab/8399: * gdb.threads/tls.exp: Remove kfail. Update expected output. Index: dwarf2loc.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2loc.c,v retrieving revision 1.97 diff -u -r1.97 dwarf2loc.c --- dwarf2loc.c 12 Aug 2010 19:55:38 -0000 1.97 +++ dwarf2loc.c 14 Sep 2010 19:37:26 -0000 @@ -1940,7 +1940,7 @@ struct symbol *framefunc; int frame_reg = 0; LONGEST frame_offset; - const gdb_byte *base_data, *new_data; + const gdb_byte *base_data, *new_data, *save_data = data; size_t base_size; LONGEST base_offset = 0; @@ -1984,10 +1984,7 @@ { /* We don't know what to do with the frame base expression, so we can't trace this variable; give up. */ - error (_("Cannot describe location of symbol \"%s\"; " - "DWARF 2 encoding not handled, " - "first opcode in base data is 0x%x."), - SYMBOL_PRINT_NAME (symbol), base_data[0]); + return save_data; } regno = gdbarch_dwarf2_reg_to_regnum (gdbarch, frame_reg); Index: testsuite/gdb.threads/tls.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/tls.exp,v retrieving revision 1.13 diff -u -r1.13 tls.exp --- testsuite/gdb.threads/tls.exp 14 Sep 2010 19:08:30 -0000 1.13 +++ testsuite/gdb.threads/tls.exp 14 Sep 2010 19:37:28 -0000 @@ -284,8 +284,8 @@ gdb_test "info address a_global" \ ".*a_global.*static storage at address.*" "info address a_global" -setup_kfail "gdb/1294" "*-*-*" -gdb_test "info address me" ".*me.*is a variable at offset.*" "info address me" +gdb_test "info address me" ".*me.*is a complex DWARF expression:.*" \ + "info address me" # Test LOC_UNRESOLVED references resolving for `extern' TLS variables.