From: Andreas Schwab <schwab@linux-m68k.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: teawater@gmail.com, gdb-patches@sourceware.org, msnyder@vmware.com
Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
Date: Sun, 30 Aug 2009 14:37:00 -0000 [thread overview]
Message-ID: <m2skf9mlio.fsf@igel.home> (raw)
In-Reply-To: <200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> (Mark Kettenis's message of "Sun, 30 Aug 2009 15:56:24 +0200 (CEST)")
Mark Kettenis <mark.kettenis@xs4all.nl> writes:
>> From: Hui Zhu <teawater@gmail.com>
>> Date: Sun, 30 Aug 2009 21:15:22 +0800
>>
>> Index: gdb/i386-linux-tdep.c
>> ===================================================================
>> --- gdb.orig/i386-linux-tdep.c 2009-08-23 21:17:37.000000000 +0800
>> +++ gdb/i386-linux-tdep.c 2009-08-30 20:19:53.828125000 +0800
>> @@ -374,7 +374,7 @@
>> if (tmpu32 > 499)
Also, magic numbers like this are bad as well.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-08-30 14:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 13:56 Hui Zhu
2009-08-30 14:09 ` Mark Kettenis
2009-08-30 14:20 ` Hui Zhu
2009-08-30 15:00 ` Hui Zhu
2009-08-31 8:46 ` Hui Zhu
2009-08-31 8:49 ` Jiang Jilin
2009-08-31 12:05 ` Hui Zhu
2009-08-31 16:33 ` Mark Kettenis
2009-09-01 2:15 ` Hui Zhu
2009-09-05 20:34 ` Michael Snyder
2009-09-05 21:15 ` Joel Brobecker
2009-09-06 4:15 ` Hui Zhu
2009-09-09 2:22 ` Hui Zhu
2009-09-09 3:31 ` Michael Snyder
2009-09-09 5:59 ` Hui Zhu
2009-08-30 14:37 ` Andreas Schwab [this message]
2009-08-30 15:14 ` Hui Zhu
2009-08-30 15:22 ` Jiang Jilin
2009-08-30 18:00 ` Hui Zhu
2009-08-30 23:43 ` Jiang Jilin
2009-08-30 23:53 ` Hui Zhu
2009-08-31 0:32 ` Jiang Jilin
2009-08-31 2:52 ` Jiang Jilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2skf9mlio.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox