From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Hui Zhu <teawater@gmail.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
freephp@gmail.com
Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
Date: Sat, 05 Sep 2009 21:15:00 -0000 [thread overview]
Message-ID: <20090905211541.GC30677@adacore.com> (raw)
In-Reply-To: <4AA2CAFA.809@vmware.com>
> I could suggest casting it to (unsigned int), but it wouldn't
> really make any difference, would it? Mark -- Jiang -- would
> that make you guys more comfortable?
Short term, I'd rather see us read the syscall number as a signed
number since this is what record_linux_system_call expects. We can
decide whether to rationalize as a signed or unsigned as a separate
patch. I think Mark was OK with the patch I sent yesterday, except
that he said we should add a check against negative values.
There is also a cast that is unnecessary in the error message.
Hui can use %s/paddress rather than %d/cast.
--
Joel
next prev parent reply other threads:[~2009-09-05 21:15 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 13:56 Hui Zhu
2009-08-30 14:09 ` Mark Kettenis
2009-08-30 14:20 ` Hui Zhu
2009-08-30 15:00 ` Hui Zhu
2009-08-31 8:46 ` Hui Zhu
2009-08-31 8:49 ` Jiang Jilin
2009-08-31 12:05 ` Hui Zhu
2009-08-31 16:33 ` Mark Kettenis
2009-09-01 2:15 ` Hui Zhu
2009-09-05 20:34 ` Michael Snyder
2009-09-05 21:15 ` Joel Brobecker [this message]
2009-09-06 4:15 ` Hui Zhu
2009-09-09 2:22 ` Hui Zhu
2009-09-09 3:31 ` Michael Snyder
2009-09-09 5:59 ` Hui Zhu
2009-08-30 14:37 ` Andreas Schwab
2009-08-30 15:14 ` Hui Zhu
2009-08-30 15:22 ` Jiang Jilin
2009-08-30 18:00 ` Hui Zhu
2009-08-30 23:43 ` Jiang Jilin
2009-08-30 23:53 ` Hui Zhu
2009-08-31 0:32 ` Jiang Jilin
2009-08-31 2:52 ` Jiang Jilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090905211541.GC30677@adacore.com \
--to=brobecker@adacore.com \
--cc=freephp@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox