From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4804 invoked by alias); 5 Sep 2009 21:15:55 -0000 Received: (qmail 4760 invoked by uid 22791); 5 Sep 2009 21:15:54 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_LWSHORTT X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 05 Sep 2009 21:15:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4B81F2BABDF; Sat, 5 Sep 2009 17:15:46 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kMfE2xje4d18; Sat, 5 Sep 2009 17:15:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F03C62BAB87; Sat, 5 Sep 2009 17:15:45 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 455AEF5915; Sat, 5 Sep 2009 14:15:41 -0700 (PDT) Date: Sat, 05 Sep 2009 21:15:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: Hui Zhu , Mark Kettenis , "gdb-patches@sourceware.org" , freephp@gmail.com Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c Message-ID: <20090905211541.GC30677@adacore.com> References: <200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> <4AA2CAFA.809@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AA2CAFA.809@vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00135.txt.bz2 > I could suggest casting it to (unsigned int), but it wouldn't > really make any difference, would it? Mark -- Jiang -- would > that make you guys more comfortable? Short term, I'd rather see us read the syscall number as a signed number since this is what record_linux_system_call expects. We can decide whether to rationalize as a signed or unsigned as a separate patch. I think Mark was OK with the patch I sent yesterday, except that he said we should add a check against negative values. There is also a cast that is unnecessary in the error message. Hui can use %s/paddress rather than %d/cast. -- Joel