From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: teawater@gmail.com
Cc: freephp@gmail.com, mark.kettenis@xs4all.nl,
gdb-patches@sourceware.org, msnyder@vmware.com
Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
Date: Mon, 31 Aug 2009 16:33:00 -0000 [thread overview]
Message-ID: <200908311546.n7VFkB7b012586@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <daef60380908310148hcdf0292oabb202913786132c@mail.gmail.com> (message from Hui Zhu on Mon, 31 Aug 2009 16:48:33 +0800)
> From: Hui Zhu <teawater@gmail.com>
> Date: Mon, 31 Aug 2009 16:48:33 +0800
>
> On Mon, Aug 31, 2009 at 16:45, Jiang Jilin<freephp@gmail.com> wrote:
> >
> > I think it's not very sensible to cast unsigned to signed, think about
> > if the unsigned value is _very_ big.
> >
>
> This is syscall id, it will not _very_ big.
Jiang has a point here though. The cast is weird, and only there
because it seems you can't make up your mind whether syscall numbers
are signed or unsigned. Some bits of code use signed integers and
some use unsigned integers. Once that inconsistency is fixed, all
these problems will disappear.
Mark
next prev parent reply other threads:[~2009-08-31 15:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 13:56 Hui Zhu
2009-08-30 14:09 ` Mark Kettenis
2009-08-30 14:20 ` Hui Zhu
2009-08-30 15:00 ` Hui Zhu
2009-08-31 8:46 ` Hui Zhu
2009-08-31 8:49 ` Jiang Jilin
2009-08-31 12:05 ` Hui Zhu
2009-08-31 16:33 ` Mark Kettenis [this message]
2009-09-01 2:15 ` Hui Zhu
2009-09-05 20:34 ` Michael Snyder
2009-09-05 21:15 ` Joel Brobecker
2009-09-06 4:15 ` Hui Zhu
2009-09-09 2:22 ` Hui Zhu
2009-09-09 3:31 ` Michael Snyder
2009-09-09 5:59 ` Hui Zhu
2009-08-30 14:37 ` Andreas Schwab
2009-08-30 15:14 ` Hui Zhu
2009-08-30 15:22 ` Jiang Jilin
2009-08-30 18:00 ` Hui Zhu
2009-08-30 23:43 ` Jiang Jilin
2009-08-30 23:53 ` Hui Zhu
2009-08-31 0:32 ` Jiang Jilin
2009-08-31 2:52 ` Jiang Jilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908311546.n7VFkB7b012586@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=freephp@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox