From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66386-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2765 invoked by alias); 31 Aug 2009 15:46:25 -0000
Received: (qmail 2754 invoked by uid 22791); 31 Aug 2009 15:46:24 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Aug 2009 15:46:19 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id n7VFkD1i009813; 	Mon, 31 Aug 2009 17:46:13 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id n7VFkB7b012586; 	Mon, 31 Aug 2009 17:46:11 +0200 (CEST)
Date: Mon, 31 Aug 2009 16:33:00 -0000
Message-Id: <200908311546.n7VFkB7b012586@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: teawater@gmail.com
CC: freephp@gmail.com, mark.kettenis@xs4all.nl, gdb-patches@sourceware.org,         msnyder@vmware.com
In-reply-to: <daef60380908310148hcdf0292oabb202913786132c@mail.gmail.com> 	(message from Hui Zhu on Mon, 31 Aug 2009 16:48:33 +0800)
Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c
References: <daef60380908300615u40f59a38t7d2c2f2252c5924d@mail.gmail.com>  	<200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> <daef60380908300709i382261c9w6152a694dcdb5975@mail.gmail.com>  	<daef60380908300737k239bf7dcp6b4eb99c3b23b6f6@mail.gmail.com>  	<daef60380908310122w5ff65266wdb1a6667bdc8407f@mail.gmail.com>  	<7d77a27d0908310145w2bcafc4bq2ed9bbd2ccff3d03@mail.gmail.com> <daef60380908310148hcdf0292oabb202913786132c@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00585.txt.bz2

> From: Hui Zhu <teawater@gmail.com>
> Date: Mon, 31 Aug 2009 16:48:33 +0800
> 
> On Mon, Aug 31, 2009 at 16:45, Jiang Jilin<freephp@gmail.com> wrote:
> >
> > I think it's not very sensible to cast unsigned to signed, think about
> > if the unsigned value is _very_ big.
> >
> 
> This is syscall id, it will not _very_ big.

Jiang has a point here though.  The cast is weird, and only there
because it seems you can't make up your mind whether syscall numbers
are signed or unsigned.  Some bits of code use signed integers and
some use unsigned integers.  Once that inconsistency is fixed, all
these problems will disappear.

Mark