From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24063 invoked by alias); 30 Aug 2009 14:20:11 -0000 Received: (qmail 24053 invoked by uid 22791); 30 Aug 2009 14:20:10 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 30 Aug 2009 14:20:04 +0000 Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id 946821C15444; Sun, 30 Aug 2009 16:20:00 +0200 (CEST) Received: from localhost (dynscan2.mnet-online.de [192.168.1.215]) by mail.m-online.net (Postfix) with ESMTP id 7D2439042C; Sun, 30 Aug 2009 16:20:00 +0200 (CEST) Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan2.mnet-online.de [192.168.1.215]) (amavisd-new, port 10024) with ESMTP id LQ1rpDRwFOKI; Sun, 30 Aug 2009 16:19:59 +0200 (CEST) Received: from igel.home (DSL01.83.171.190.2.ip-pool.NEFkom.net [83.171.190.2]) by mail.mnet-online.de (Postfix) with ESMTP; Sun, 30 Aug 2009 16:19:59 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 1F9DD10DBF9; Sun, 30 Aug 2009 16:19:59 +0200 (CEST) From: Andreas Schwab To: Mark Kettenis Cc: teawater@gmail.com, gdb-patches@sourceware.org, msnyder@vmware.com Subject: Re: [PATCH] Fix cygwin build error with i386-linux-tdep.c References: <200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> X-Yow: On SECOND thought, maybe I'll heat up some BAKED BEANS and watch REGIS PHILBIN.. It's GREAT to be ALIVE!! Date: Sun, 30 Aug 2009 14:37:00 -0000 In-Reply-To: <200908301356.n7UDuO4a006136@brahms.sibelius.xs4all.nl> (Mark Kettenis's message of "Sun, 30 Aug 2009 15:56:24 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00563.txt.bz2 Mark Kettenis writes: >> From: Hui Zhu >> Date: Sun, 30 Aug 2009 21:15:22 +0800 >> >> Index: gdb/i386-linux-tdep.c >> =================================================================== >> --- gdb.orig/i386-linux-tdep.c 2009-08-23 21:17:37.000000000 +0800 >> +++ gdb/i386-linux-tdep.c 2009-08-30 20:19:53.828125000 +0800 >> @@ -374,7 +374,7 @@ >> if (tmpu32 > 499) Also, magic numbers like this are bad as well. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."