Re: [RFC] h8300 "info registers" fix

[Yoshinori Sato <ysato@users.sourceforge.jp>]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

At Wed, 13 Sep 2006 00:04:58 +0900,
Yoshinori Sato wrote:
> 
> [1  <text/plain; US-ASCII (7bit)>]
> A result of ccr and exr mistakes by a "info registers" of h8300 target.
> There was two faults.
> 
> - A name of E_CCR_REGNUM is not defined with h8300_register_name.
>   Accordingly regcache_raw_read of h8300_pseudo_regitser_read fails.
> - Assume size of E_PSEUDO_CCR_REGNUM by 1 byte with h8300_register_type.
>   But assume 4 bytes from a remote target.
>   Accordingly cannot take response of remote side to be really.
> 
> I correct an issue of a thing of the patch box which I attached.
> The issue was corrected, but not know you whether this is good technique.
> 
> -- 
> Yoshinori Sato
> <ysato@users.sourceforge.jp>
> 

I modified it in technique to think that I was appropriate.

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>


[-- Attachment #2: h8300-tdep.diff --]
[-- Type: application/octet-stream, Size: 2877 bytes --]

? h8300-tdep.diff
Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.7897
diff -u -r1.7897 ChangeLog
--- ChangeLog	10 Sep 2006 16:21:03 -0000	1.7897
+++ ChangeLog	13 Sep 2006 15:49:27 -0000
@@ -1,3 +1,11 @@
+2006-09-13  Yoshinori Sato  <ysato@users.sourceforge.jp>
+
+	* h8300-tdep.c (h8300_pseud_register_read): fix E_CCR_REGNUM 
+	and E_EXR_REGNUM size. 
+	(h8300_pseudo_register_write): Ditto.
+	(h8300_sim_register_regno): New function.
+	(h8300_h8300_gdbarch_init): add regist h8300_sim_register_regno.
+
 2006-09-10  Daniel Jacobowitz  <dan@codesourcery.com>
 
 	PR threads/2149
Index: h8300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/h8300-tdep.c,v
retrieving revision 1.103
diff -u -r1.103 h8300-tdep.c
--- h8300-tdep.c	17 Dec 2005 22:34:00 -0000	1.103
+++ h8300-tdep.c	13 Sep 2006 15:49:28 -0000
@@ -1148,10 +1148,18 @@
 			    struct regcache *regcache, int regno,
 			    gdb_byte *buf)
 {
+  gdb_byte tmp[4];
+
   if (regno == E_PSEUDO_CCR_REGNUM)
-    regcache_raw_read (regcache, E_CCR_REGNUM, buf);
+    {
+      regcache_raw_read (regcache, E_CCR_REGNUM, tmp);
+      *buf = tmp[3];
+    }
   else if (regno == E_PSEUDO_EXR_REGNUM)
-    regcache_raw_read (regcache, E_EXR_REGNUM, buf);
+    {
+      regcache_raw_read (regcache, E_EXR_REGNUM, tmp);
+      *buf = tmp[3];
+    }
   else
     regcache_raw_read (regcache, regno, buf);
 }
@@ -1161,10 +1169,18 @@
 			     struct regcache *regcache, int regno,
 			     const gdb_byte *buf)
 {
+  unsigned long tmp;
+
   if (regno == E_PSEUDO_CCR_REGNUM)
-    regcache_raw_write (regcache, E_CCR_REGNUM, buf);
+    {
+      tmp = extract_unsigned_integer(buf, 1);
+      regcache_raw_write (regcache, E_CCR_REGNUM, (gdb_byte *)&tmp);
+    }
   else if (regno == E_PSEUDO_EXR_REGNUM)
-    regcache_raw_write (regcache, E_EXR_REGNUM, buf);
+    {
+      tmp = extract_unsigned_integer(buf, 1);
+      regcache_raw_write (regcache, E_EXR_REGNUM, (gdb_byte *)&tmp);
+    }
   else
     regcache_raw_write (regcache, regno, buf);
 }
@@ -1205,6 +1221,19 @@
 No floating-point info available for this processor.\n");
 }
 
+static int
+h8300_register_sim_regno (int regno)
+{
+  switch (regno)
+    {
+    case E_CCR_REGNUM:
+    case E_EXR_REGNUM:
+      return regno;
+    default:
+      return legacy_register_sim_regno (regno);
+    }
+}
+
 static struct gdbarch *
 h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 {
@@ -1319,6 +1348,7 @@
   set_gdbarch_register_type (gdbarch, h8300_register_type);
   set_gdbarch_print_registers_info (gdbarch, h8300_print_registers_info);
   set_gdbarch_print_float_info (gdbarch, h8300_print_float_info);
+  set_gdbarch_register_sim_regno(gdbarch, h8300_register_sim_regno);
 
   /*
    * Frame Info