Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] h8300 "info registers" fix
Date: Tue, 19 Sep 2006 16:28:00 -0000	[thread overview]
Message-ID: <m2odtbvn1p.wl%ysato@users.sourceforge.jp> (raw)
In-Reply-To: <m23bax9ld1.wl%ysato@users.sourceforge.jp>

I corrected it not to depend on endian.

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.7901
diff -u -r1.7901 ChangeLog
--- ChangeLog	17 Sep 2006 15:48:34 -0000	1.7901
+++ ChangeLog	19 Sep 2006 15:55:15 -0000
@@ -1,3 +1,11 @@
+2006-09-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
+
+	* h8300-tdep.c (h8300_pseud_register_read): fix E_CCR_REGNUM 
+	and E_EXR_REGNUM size. 
+	(h8300_pseudo_register_write): Ditto.
+	(h8300_sim_register_regno): New function.
+	(h8300_h8300_gdbarch_init): add regist h8300_sim_register_regno.
+
 2006-09-17  Vladimir Prus  <vladimir@codesourcery.com>
 
 	* mi/mi-cmd-stack.c (mi_cmd_stack_list_args): Don't emit error
Index: h8300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/h8300-tdep.c,v
retrieving revision 1.103
diff -u -r1.103 h8300-tdep.c
--- h8300-tdep.c	17 Dec 2005 22:34:00 -0000	1.103
+++ h8300-tdep.c	19 Sep 2006 15:55:15 -0000
@@ -1148,10 +1148,20 @@
 			    struct regcache *regcache, int regno,
 			    gdb_byte *buf)
 {
+  unsigned long tmp;
+
   if (regno == E_PSEUDO_CCR_REGNUM)
-    regcache_raw_read (regcache, E_CCR_REGNUM, buf);
+    {
+      regcache_raw_read (regcache, E_CCR_REGNUM, (gdb_byte *)&tmp);
+      store_unsigned_integer((gdb_byte *)&tmp, 4, tmp);
+      *buf = tmp;
+    }
   else if (regno == E_PSEUDO_EXR_REGNUM)
-    regcache_raw_read (regcache, E_EXR_REGNUM, buf);
+    {
+      regcache_raw_read (regcache, E_EXR_REGNUM, (gdb_byte *)&tmp);
+      store_unsigned_integer((gdb_byte *)&tmp, 4, tmp);
+      *buf = tmp;
+    }
   else
     regcache_raw_read (regcache, regno, buf);
 }
@@ -1161,10 +1171,18 @@
 			     struct regcache *regcache, int regno,
 			     const gdb_byte *buf)
 {
+  unsigned long tmp;
+
   if (regno == E_PSEUDO_CCR_REGNUM)
-    regcache_raw_write (regcache, E_CCR_REGNUM, buf);
+    {
+      tmp = extract_unsigned_integer(buf, 1);
+      regcache_raw_write (regcache, E_CCR_REGNUM, (gdb_byte *)&tmp);
+    }
   else if (regno == E_PSEUDO_EXR_REGNUM)
-    regcache_raw_write (regcache, E_EXR_REGNUM, buf);
+    {
+      tmp = extract_unsigned_integer(buf, 1);
+      regcache_raw_write (regcache, E_EXR_REGNUM, (gdb_byte *)&tmp);
+    }
   else
     regcache_raw_write (regcache, regno, buf);
 }
@@ -1205,6 +1223,19 @@
 No floating-point info available for this processor.\n");
 }
 
+static int
+h8300_register_sim_regno (int regno)
+{
+  switch (regno)
+    {
+    case E_CCR_REGNUM:
+    case E_EXR_REGNUM:
+      return regno;
+    default:
+      return legacy_register_sim_regno (regno);
+    }
+}
+
 static struct gdbarch *
 h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 {
@@ -1319,6 +1350,7 @@
   set_gdbarch_register_type (gdbarch, h8300_register_type);
   set_gdbarch_print_registers_info (gdbarch, h8300_print_registers_info);
   set_gdbarch_print_float_info (gdbarch, h8300_print_float_info);
+  set_gdbarch_register_sim_regno(gdbarch, h8300_register_sim_regno);
 
   /*
    * Frame Info

-- 
Yoshinori Sato
<ysato@users.sourceforge.jp>


  parent reply	other threads:[~2006-09-19 16:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-12 15:05 Yoshinori Sato
2006-09-12 20:28 ` Michael Snyder
2006-09-13  2:28   ` Yoshinori Sato
2006-09-13 15:54 ` Yoshinori Sato
2006-09-13 20:05   ` Michael Snyder
2006-09-13 20:09     ` Daniel Jacobowitz
2006-09-13 20:23       ` Michael Snyder
2006-09-13 20:30         ` Daniel Jacobowitz
2006-09-13 20:59           ` Michael Snyder
2006-09-23  1:08             ` Mark Kettenis
2006-09-23  1:06           ` Mark Kettenis
2006-09-23  3:20             ` Jim Blandy
2006-09-23  3:26               ` Daniel Jacobowitz
2006-09-14  9:40     ` Yoshinori Sato
2006-09-19 16:28 ` Yoshinori Sato [this message]
2006-09-23 18:00   ` Mark Kettenis
2006-11-16  8:30     ` Yoshinori Sato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2odtbvn1p.wl%ysato@users.sourceforge.jp \
    --to=ysato@users.sourceforge.jp \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox