From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29982 invoked by alias); 13 Sep 2006 15:54:39 -0000 Received: (qmail 29972 invoked by uid 22791); 13 Sep 2006 15:54:39 -0000 X-Spam-Check-By: sourceware.org Received: from mail2.asahi-net.or.jp (HELO mail.asahi-net.or.jp) (202.224.39.198) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 13 Sep 2006 15:54:34 +0000 Received: from mitou.ysato.dip.jp (l247150.ppp.asahi-net.or.jp [218.219.247.150]) by mail.asahi-net.or.jp (Postfix) with ESMTP id F0608CFAF for ; Thu, 14 Sep 2006 00:54:30 +0900 (JST) Received: from mitou.localdomain (unknown [192.168.16.2]) by mitou.ysato.dip.jp (Postfix) with ESMTP id D4F161C18A for ; Thu, 14 Sep 2006 00:54:30 +0900 (JST) Date: Wed, 13 Sep 2006 15:54:00 -0000 Message-ID: From: Yoshinori Sato To: gdb-patches Subject: Re: [RFC] h8300 "info registers" fix In-Reply-To: References: User-Agent: Wanderlust/2.15.3 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.50 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: multipart/mixed; boundary="Multipart_Thu_Sep_14_00:54:30_2006-1" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-09/txt/msg00063.txt.bz2 --Multipart_Thu_Sep_14_00:54:30_2006-1 Content-Type: text/plain; charset=US-ASCII Content-length: 841 At Wed, 13 Sep 2006 00:04:58 +0900, Yoshinori Sato wrote: > > [1 ] > A result of ccr and exr mistakes by a "info registers" of h8300 target. > There was two faults. > > - A name of E_CCR_REGNUM is not defined with h8300_register_name. > Accordingly regcache_raw_read of h8300_pseudo_regitser_read fails. > - Assume size of E_PSEUDO_CCR_REGNUM by 1 byte with h8300_register_type. > But assume 4 bytes from a remote target. > Accordingly cannot take response of remote side to be really. > > I correct an issue of a thing of the patch box which I attached. > The issue was corrected, but not know you whether this is good technique. > > -- > Yoshinori Sato > > I modified it in technique to think that I was appropriate. -- Yoshinori Sato --Multipart_Thu_Sep_14_00:54:30_2006-1 Content-Type: application/octet-stream; type=patch Content-Disposition: attachment; filename="h8300-tdep.diff" Content-Transfer-Encoding: 7bit Content-length: 2877 ? h8300-tdep.diff Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.7897 diff -u -r1.7897 ChangeLog --- ChangeLog 10 Sep 2006 16:21:03 -0000 1.7897 +++ ChangeLog 13 Sep 2006 15:49:27 -0000 @@ -1,3 +1,11 @@ +2006-09-13 Yoshinori Sato + + * h8300-tdep.c (h8300_pseud_register_read): fix E_CCR_REGNUM + and E_EXR_REGNUM size. + (h8300_pseudo_register_write): Ditto. + (h8300_sim_register_regno): New function. + (h8300_h8300_gdbarch_init): add regist h8300_sim_register_regno. + 2006-09-10 Daniel Jacobowitz PR threads/2149 Index: h8300-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/h8300-tdep.c,v retrieving revision 1.103 diff -u -r1.103 h8300-tdep.c --- h8300-tdep.c 17 Dec 2005 22:34:00 -0000 1.103 +++ h8300-tdep.c 13 Sep 2006 15:49:28 -0000 @@ -1148,10 +1148,18 @@ struct regcache *regcache, int regno, gdb_byte *buf) { + gdb_byte tmp[4]; + if (regno == E_PSEUDO_CCR_REGNUM) - regcache_raw_read (regcache, E_CCR_REGNUM, buf); + { + regcache_raw_read (regcache, E_CCR_REGNUM, tmp); + *buf = tmp[3]; + } else if (regno == E_PSEUDO_EXR_REGNUM) - regcache_raw_read (regcache, E_EXR_REGNUM, buf); + { + regcache_raw_read (regcache, E_EXR_REGNUM, tmp); + *buf = tmp[3]; + } else regcache_raw_read (regcache, regno, buf); } @@ -1161,10 +1169,18 @@ struct regcache *regcache, int regno, const gdb_byte *buf) { + unsigned long tmp; + if (regno == E_PSEUDO_CCR_REGNUM) - regcache_raw_write (regcache, E_CCR_REGNUM, buf); + { + tmp = extract_unsigned_integer(buf, 1); + regcache_raw_write (regcache, E_CCR_REGNUM, (gdb_byte *)&tmp); + } else if (regno == E_PSEUDO_EXR_REGNUM) - regcache_raw_write (regcache, E_EXR_REGNUM, buf); + { + tmp = extract_unsigned_integer(buf, 1); + regcache_raw_write (regcache, E_EXR_REGNUM, (gdb_byte *)&tmp); + } else regcache_raw_write (regcache, regno, buf); } @@ -1205,6 +1221,19 @@ No floating-point info available for this processor.\n"); } +static int +h8300_register_sim_regno (int regno) +{ + switch (regno) + { + case E_CCR_REGNUM: + case E_EXR_REGNUM: + return regno; + default: + return legacy_register_sim_regno (regno); + } +} + static struct gdbarch * h8300_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) { @@ -1319,6 +1348,7 @@ set_gdbarch_register_type (gdbarch, h8300_register_type); set_gdbarch_print_registers_info (gdbarch, h8300_print_registers_info); set_gdbarch_print_float_info (gdbarch, h8300_print_float_info); + set_gdbarch_register_sim_regno(gdbarch, h8300_register_sim_regno); /* * Frame Info --Multipart_Thu_Sep_14_00:54:30_2006-1--