Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: lvalues and variable_editable
Date: Tue, 20 Nov 2007 13:39:00 -0000	[thread overview]
Message-ID: <loom.20071120T133620-668@post.gmane.org> (raw)
In-Reply-To: <18221.183.198223.704715@kahikatea.snap.net.nz>

Nick Roberts <nickrob <at> snap.net.nz> writes:

>  > I believe this test captures CPLUS_FAKE_CHILD as well, so you don't
>  > need to have separate test for that.
> 
> I'll remove it.
...
>  > >     /* FIXME: define masks for attributes */
>  > > !   if (!varobj_editable_p (var))
>  > >       error (_("mi_cmd_var_assign: Variable object is not editable"));
>  > 
>  > I presume the FIXME is now stale?
> 
> I'll remove that too
...
>  >  Aside from the minor points above, I don't have any objections to this
>  > patch. Dan, what would you say?

Just to clarify -- who's got the ball now? Nick, are you planning to post a 
revised patch, or are you waiting for Dan to approve the reminder of the patch?

- Volodya


  reply	other threads:[~2007-11-20 13:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26 22:59 Nick Roberts
2007-10-27  6:29 ` Vladimir Prus
2007-10-27 12:15   ` Nick Roberts
2007-10-27 14:22     ` Vladimir Prus
2007-10-30  8:55       ` Nick Roberts
2007-10-30  9:55         ` Vladimir Prus
2007-10-30 11:15           ` Nick Roberts
2007-10-30 13:41             ` Daniel Jacobowitz
2007-10-30 18:30               ` Nick Roberts
2007-10-30 19:26                 ` Daniel Jacobowitz
2007-10-30 19:27                   ` Daniel Jacobowitz
2007-11-01  4:42               ` Nick Roberts
2007-10-31 14:16             ` Vladimir Prus
2007-11-01  4:52               ` Nick Roberts
2007-11-01  7:52                 ` Vladimir Prus
2007-11-01 15:40                   ` Daniel Jacobowitz
2007-11-02  4:23                     ` Nick Roberts
2007-11-02 11:36                       ` Daniel Jacobowitz
2007-11-03  9:23                         ` Nick Roberts
2007-11-03  9:48                           ` Vladimir Prus
2007-11-03 23:14                             ` Nick Roberts
2007-11-20 13:39                               ` Vladimir Prus [this message]
2007-11-03 11:09                           ` Nick Roberts
2007-11-20 13:55                           ` Daniel Jacobowitz
2007-11-20 19:55                             ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20071120T133620-668@post.gmane.org \
    --to=vladimir@codesourcery.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox