From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: Vladimir Prus <ghost@cs.msu.su>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: lvalues and variable_editable
Date: Tue, 20 Nov 2007 13:55:00 -0000 [thread overview]
Message-ID: <20071120135528.GA19647@caradoc.them.org> (raw)
In-Reply-To: <18220.15856.752225.9086@kahikatea.snap.net.nz>
On Sat, Nov 03, 2007 at 10:22:56PM +1300, Nick Roberts wrote:
> + if (!(var->root->is_valid && var->value && VALUE_LVAL(var->value)))
> + return 0;
Space before parenthesis.
> /* FIXME: define masks for attributes */
> ! if (!varobj_editable_p (var))
> error (_("mi_cmd_var_assign: Variable object is not editable"));
> + else
> + {
> + expression = xstrdup (argv[1]);
No need to move all this code into an else; error will never return.
The patch seems fine to me, with Vladimir's comments.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-11-20 13:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 22:59 Nick Roberts
2007-10-27 6:29 ` Vladimir Prus
2007-10-27 12:15 ` Nick Roberts
2007-10-27 14:22 ` Vladimir Prus
2007-10-30 8:55 ` Nick Roberts
2007-10-30 9:55 ` Vladimir Prus
2007-10-30 11:15 ` Nick Roberts
2007-10-30 13:41 ` Daniel Jacobowitz
2007-10-30 18:30 ` Nick Roberts
2007-10-30 19:26 ` Daniel Jacobowitz
2007-10-30 19:27 ` Daniel Jacobowitz
2007-11-01 4:42 ` Nick Roberts
2007-10-31 14:16 ` Vladimir Prus
2007-11-01 4:52 ` Nick Roberts
2007-11-01 7:52 ` Vladimir Prus
2007-11-01 15:40 ` Daniel Jacobowitz
2007-11-02 4:23 ` Nick Roberts
2007-11-02 11:36 ` Daniel Jacobowitz
2007-11-03 9:23 ` Nick Roberts
2007-11-03 9:48 ` Vladimir Prus
2007-11-03 23:14 ` Nick Roberts
2007-11-20 13:39 ` Vladimir Prus
2007-11-03 11:09 ` Nick Roberts
2007-11-20 13:55 ` Daniel Jacobowitz [this message]
2007-11-20 19:55 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120135528.GA19647@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox