Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] MI: lvalues and variable_editable
Date: Wed, 31 Oct 2007 14:16:00 -0000	[thread overview]
Message-ID: <200710311458.58112.ghost@cs.msu.su> (raw)
In-Reply-To: <18215.4053.151140.671560@kahikatea.snap.net.nz>

On Tuesday 30 October 2007 14:04:53 Nick Roberts wrote:
>  > I believe that var->value will be NULL.
> 
> Yes, that looks good.  I'll use:
> 
>   if (!var->value || !VALUE_LVAL(var->value))
>     return 0;
> 
> and that should keep us both happy.

As long there which code *replaces* gdb_evaluate_expression, I'm 
perfectly happy. Thanks!

>  >                                                                        GDB,
>  > as it stands, allows you to create a variable object in any frame, and your
>  > patch does not work with that. So, either creating variable objects in any
>  > frame should be disallowed, 
> 
> Actually I think that would be a good idea.  Generally a user would create a
> watch expression in the frame he's examining.  If not, the frontend would have
> to prompt for the frame.  Does KDevelop do this?

At the moment, KDevelop does not have any command that would create varobj
in non-current frame (although it's possible to create varobj in one frame,
and then assign to it while the current frame is different).
 
Daniel Jacobowitz later wrote:

> > Actually I think that would be a good idea.  Generally a user would
> > create a watch expression in the frame he's examining.  If not, the
> > frontend would have to prompt for the frame.  Does KDevelop do this?
>
> If you have a GUI with a stack pane, it may be showing a lot of frames
> at once.  Why force the front end to select a frmae before creating
> the varobj?

Yeah. For example, if stack widgets shows variables it would be quite
reasonable to allow expanding a variable, and creating varobj for
some nested field, and there's no need to switch frames.

(The problem with switching frames is that GUI and gdb will be temporary
out-of-sync, and generally all cases where GUI and gdb are out of sync
lead to bugs).

- Volodya


  parent reply	other threads:[~2007-10-31 11:59 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26 22:59 Nick Roberts
2007-10-27  6:29 ` Vladimir Prus
2007-10-27 12:15   ` Nick Roberts
2007-10-27 14:22     ` Vladimir Prus
2007-10-30  8:55       ` Nick Roberts
2007-10-30  9:55         ` Vladimir Prus
2007-10-30 11:15           ` Nick Roberts
2007-10-30 13:41             ` Daniel Jacobowitz
2007-10-30 18:30               ` Nick Roberts
2007-10-30 19:26                 ` Daniel Jacobowitz
2007-10-30 19:27                   ` Daniel Jacobowitz
2007-11-01  4:42               ` Nick Roberts
2007-10-31 14:16             ` Vladimir Prus [this message]
2007-11-01  4:52               ` Nick Roberts
2007-11-01  7:52                 ` Vladimir Prus
2007-11-01 15:40                   ` Daniel Jacobowitz
2007-11-02  4:23                     ` Nick Roberts
2007-11-02 11:36                       ` Daniel Jacobowitz
2007-11-03  9:23                         ` Nick Roberts
2007-11-03  9:48                           ` Vladimir Prus
2007-11-03 23:14                             ` Nick Roberts
2007-11-20 13:39                               ` Vladimir Prus
2007-11-03 11:09                           ` Nick Roberts
2007-11-20 13:55                           ` Daniel Jacobowitz
2007-11-20 19:55                             ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710311458.58112.ghost@cs.msu.su \
    --to=ghost@cs.msu.su \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox