From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17405 invoked by alias); 20 Nov 2007 13:55:38 -0000 Received: (qmail 17387 invoked by uid 22791); 20 Nov 2007 13:55:37 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 Nov 2007 13:55:30 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7E33698368; Tue, 20 Nov 2007 13:55:29 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 20D8498258; Tue, 20 Nov 2007 13:55:28 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IuTZY-0005Ba-1K; Tue, 20 Nov 2007 08:55:28 -0500 Date: Tue, 20 Nov 2007 13:55:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: Vladimir Prus , gdb-patches@sources.redhat.com Subject: Re: [PATCH] MI: lvalues and variable_editable Message-ID: <20071120135528.GA19647@caradoc.them.org> Mail-Followup-To: Nick Roberts , Vladimir Prus , gdb-patches@sources.redhat.com References: <18210.27153.559569.601092@kahikatea.snap.net.nz> <200710311458.58112.ghost@cs.msu.su> <18217.23406.21406.920384@kahikatea.snap.net.nz> <200710312247.40840.ghost@cs.msu.su> <20071101153955.GA20676@caradoc.them.org> <18218.42464.899738.594153@kahikatea.snap.net.nz> <20071102113610.GA16883@caradoc.them.org> <18220.15856.752225.9086@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18220.15856.752225.9086@kahikatea.snap.net.nz> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00380.txt.bz2 On Sat, Nov 03, 2007 at 10:22:56PM +1300, Nick Roberts wrote: > + if (!(var->root->is_valid && var->value && VALUE_LVAL(var->value))) > + return 0; Space before parenthesis. > /* FIXME: define masks for attributes */ > ! if (!varobj_editable_p (var)) > error (_("mi_cmd_var_assign: Variable object is not editable")); > + else > + { > + expression = xstrdup (argv[1]); No need to move all this code into an else; error will never return. The patch seems fine to me, with Vladimir's comments. -- Daniel Jacobowitz CodeSourcery