From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8661 invoked by alias); 20 Nov 2007 13:39:39 -0000 Received: (qmail 8651 invoked by uid 22791); 20 Nov 2007 13:39:38 -0000 X-Spam-Check-By: sourceware.org Received: from main.gmane.org (HELO ciao.gmane.org) (80.91.229.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 Nov 2007 13:39:29 +0000 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IuTJk-00083v-Gr for gdb-patches@sources.redhat.com; Tue, 20 Nov 2007 13:39:08 +0000 Received: from 241-246.AKNET.ru ([241-246.AKNET.ru]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 20 Nov 2007 13:39:08 +0000 Received: from vladimir by 241-246.AKNET.ru with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 20 Nov 2007 13:39:08 +0000 To: gdb-patches@sources.redhat.com From: Vladimir Prus Subject: Re: [PATCH] MI: lvalues and =?utf-8?b?dmFyaWFibGVfZWRpdGFibGU=?= Date: Tue, 20 Nov 2007 13:39:00 -0000 Message-ID: References: <18210.27153.559569.601092@kahikatea.snap.net.nz> <20071102113610.GA16883@caradoc.them.org> <18220.15856.752225.9086@kahikatea.snap.net.nz> <200711031247.54239.ghost@cs.msu.su> <18221.183.198223.704715@kahikatea.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Loom/3.14 (http://gmane.org/) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00379.txt.bz2 Nick Roberts snap.net.nz> writes: > > I believe this test captures CPLUS_FAKE_CHILD as well, so you don't > > need to have separate test for that. > > I'll remove it. ... > > >     /* FIXME: define masks for attributes */ > > > !   if (!varobj_editable_p (var)) > > >       error (_("mi_cmd_var_assign: Variable object is not editable")); > > > > I presume the FIXME is now stale? > > I'll remove that too ... > > Aside from the minor points above, I don't have any objections to this > > patch. Dan, what would you say? Just to clarify -- who's got the ball now? Nick, are you planning to post a revised patch, or are you waiting for Dan to approve the reminder of the patch? - Volodya