Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* Fix write_pc_pid breakage
@ 2007-06-21 12:11 Andreas Schwab
  2007-06-21 13:57 ` Ulrich Weigand
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Schwab @ 2007-06-21 12:11 UTC (permalink / raw)
  To: gdb-patches

The last change to write_pc_pid broke it on targets that have no pc
register.  Committed as obvious.

Andreas.

2007-06-21  Andreas Schwab  <schwab@suse.de>

	* regcache.c (write_pc_pid): Restore missing else.

--- gdb/regcache.c.~1.159.~	2007-06-21 12:04:43.000000000 +0200
+++ gdb/regcache.c	2007-06-21 14:01:57.000000000 +0200
@@ -867,7 +867,7 @@ write_pc_pid (CORE_ADDR pc, ptid_t ptid)
 
   if (gdbarch_write_pc_p (gdbarch))
     gdbarch_write_pc (gdbarch, regcache, pc);
-  if (gdbarch_pc_regnum (current_gdbarch) >= 0)
+  else if (gdbarch_pc_regnum (current_gdbarch) >= 0)
     regcache_cooked_write_unsigned (regcache,
 				    gdbarch_pc_regnum (current_gdbarch), pc);
   else

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Fix write_pc_pid breakage
  2007-06-21 12:11 Fix write_pc_pid breakage Andreas Schwab
@ 2007-06-21 13:57 ` Ulrich Weigand
  0 siblings, 0 replies; 2+ messages in thread
From: Ulrich Weigand @ 2007-06-21 13:57 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: gdb-patches

Andreas Schwab wrote:

> The last change to write_pc_pid broke it on targets that have no pc
> register.  Committed as obvious.

Oops.  Sorry for the breakage, and thanks for fixing it.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-06-21 13:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-06-21 12:11 Fix write_pc_pid breakage Andreas Schwab
2007-06-21 13:57 ` Ulrich Weigand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox