From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28094 invoked by alias); 21 Jun 2007 12:11:13 -0000 Received: (qmail 28081 invoked by uid 22791); 21 Jun 2007 12:11:12 -0000 X-Spam-Check-By: sourceware.org Received: from ns.suse.de (HELO mx1.suse.de) (195.135.220.2) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 21 Jun 2007 12:11:09 +0000 Received: from Relay1.suse.de (mail2.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.suse.de (Postfix) with ESMTP id 626DB122E1 for ; Thu, 21 Jun 2007 14:11:07 +0200 (CEST) From: Andreas Schwab To: gdb-patches@sourceware.org Subject: Fix write_pc_pid breakage X-Yow: Mary Tyler Moore's SEVENTH HUSBAND is wearing my DACRON TANK TOP in a cheap hotel in HONOLULU! Date: Thu, 21 Jun 2007 12:11:00 -0000 Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00409.txt.bz2 The last change to write_pc_pid broke it on targets that have no pc register. Committed as obvious. Andreas. 2007-06-21 Andreas Schwab * regcache.c (write_pc_pid): Restore missing else. --- gdb/regcache.c.~1.159.~ 2007-06-21 12:04:43.000000000 +0200 +++ gdb/regcache.c 2007-06-21 14:01:57.000000000 +0200 @@ -867,7 +867,7 @@ write_pc_pid (CORE_ADDR pc, ptid_t ptid) if (gdbarch_write_pc_p (gdbarch)) gdbarch_write_pc (gdbarch, regcache, pc); - if (gdbarch_pc_regnum (current_gdbarch) >= 0) + else if (gdbarch_pc_regnum (current_gdbarch) >= 0) regcache_cooked_write_unsigned (regcache, gdbarch_pc_regnum (current_gdbarch), pc); else -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."