From: Andreas Schwab <schwab@suse.de>
To: gdb-patches@sourceware.org
Subject: Fix write_pc_pid breakage
Date: Thu, 21 Jun 2007 12:11:00 -0000 [thread overview]
Message-ID: <jesl8lzew5.fsf@sykes.suse.de> (raw)
The last change to write_pc_pid broke it on targets that have no pc
register. Committed as obvious.
Andreas.
2007-06-21 Andreas Schwab <schwab@suse.de>
* regcache.c (write_pc_pid): Restore missing else.
--- gdb/regcache.c.~1.159.~ 2007-06-21 12:04:43.000000000 +0200
+++ gdb/regcache.c 2007-06-21 14:01:57.000000000 +0200
@@ -867,7 +867,7 @@ write_pc_pid (CORE_ADDR pc, ptid_t ptid)
if (gdbarch_write_pc_p (gdbarch))
gdbarch_write_pc (gdbarch, regcache, pc);
- if (gdbarch_pc_regnum (current_gdbarch) >= 0)
+ else if (gdbarch_pc_regnum (current_gdbarch) >= 0)
regcache_cooked_write_unsigned (regcache,
gdbarch_pc_regnum (current_gdbarch), pc);
else
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next reply other threads:[~2007-06-21 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 12:11 Andreas Schwab [this message]
2007-06-21 13:57 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jesl8lzew5.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox