Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Eliminate char buf[MAX_REGISTER_RAW_SIZE]
Date: Fri, 31 Jan 2003 23:20:00 -0000	[thread overview]
Message-ID: <jehebooqja.fsf@sykes.suse.de> (raw)
In-Reply-To: <3E3AFFA5.9080902@redhat.com> (Andrew Cagney's message of "Fri, 31 Jan 2003 17:58:45 -0500")

Andrew Cagney <ac131313@redhat.com> writes:

|> Hello,
|> 
|> Since MAX_REGISTER_RAW_SIZE is implemented using a function the declaration:
|> 
|> 	  char buf[MAX_REGISTER_RAW_SIZE];
|> 
|> is illegal.  (GCC does allow it which is why no one notices :-/).
|> 
|> The attached patch updates all obvious (as in found by a grep) occurances
|> of this and changes them to:
|> 
|> 	char *buf = alloca (max_register_raw_size (current_gdbarch));

You have used max_register_size in the patch.  Which of the two is
correct?

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


  reply	other threads:[~2003-01-31 23:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-31 22:58 Andrew Cagney
2003-01-31 23:20 ` Andreas Schwab [this message]
2003-01-31 23:26   ` Andrew Cagney
2003-02-01  1:36 ` Michael Snyder
2003-02-01  6:17   ` Andrew Cagney
2003-02-01  6:13 ` Joel Brobecker
2003-02-01  6:40   ` Andrew Cagney
2003-02-02  5:36 ` Andrew Cagney
2003-02-01 17:33 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jehebooqja.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox