From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10619 invoked by alias); 31 Jan 2003 23:20:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10612 invoked from network); 31 Jan 2003 23:20:39 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by 172.16.49.205 with SMTP; 31 Jan 2003 23:20:39 -0000 Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136]) by Cantor.suse.de (Postfix) with ESMTP id 77EC71473A; Sat, 1 Feb 2003 00:20:38 +0100 (MET) To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Eliminate char buf[MAX_REGISTER_RAW_SIZE] X-Yow: They collapsed.... like nuns in the street... they had no teen appeal! From: Andreas Schwab Date: Fri, 31 Jan 2003 23:20:00 -0000 In-Reply-To: <3E3AFFA5.9080902@redhat.com> (Andrew Cagney's message of "Fri, 31 Jan 2003 17:58:45 -0500") Message-ID: User-Agent: Gnus/5.090014 (Oort Gnus v0.14) Emacs/21.3.50 (ia64-suse-linux) References: <3E3AFFA5.9080902@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2003-01/txt/msg00854.txt.bz2 Andrew Cagney writes: |> Hello, |> |> Since MAX_REGISTER_RAW_SIZE is implemented using a function the declaration: |> |> char buf[MAX_REGISTER_RAW_SIZE]; |> |> is illegal. (GCC does allow it which is why no one notices :-/). |> |> The attached patch updates all obvious (as in found by a grep) occurances |> of this and changes them to: |> |> char *buf = alloca (max_register_raw_size (current_gdbarch)); You have used max_register_size in the patch. Which of the two is correct? Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."