From: Andrew Cagney <ac131313@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Eliminate char buf[MAX_REGISTER_RAW_SIZE]
Date: Fri, 31 Jan 2003 23:26:00 -0000 [thread overview]
Message-ID: <3E3B0633.7040502@redhat.com> (raw)
In-Reply-To: <jehebooqja.fsf@sykes.suse.de>
> Andrew Cagney <ac131313@redhat.com> writes:
>
> |> Hello,
> |>
> |> Since MAX_REGISTER_RAW_SIZE is implemented using a function the declaration:
> |>
> |> char buf[MAX_REGISTER_RAW_SIZE];
> |>
> |> is illegal. (GCC does allow it which is why no one notices :-/).
> |>
> |> The attached patch updates all obvious (as in found by a grep) occurances
> |> of this and changes them to:
> |>
> |> char *buf = alloca (max_register_raw_size (current_gdbarch));
>
> You have used max_register_size in the patch. Which of the two is
> correct?
Oops, max_register_size() is correct. (I've built all the cross targets).
Hmm, I also forgot to mention that it hit both MAX_REGISTER_RAW_SIZE and
MAX_REGISTER_VIRTUAL_SIZE.
Andrew
next prev parent reply other threads:[~2003-01-31 23:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-31 22:58 Andrew Cagney
2003-01-31 23:20 ` Andreas Schwab
2003-01-31 23:26 ` Andrew Cagney [this message]
2003-02-01 1:36 ` Michael Snyder
2003-02-01 6:17 ` Andrew Cagney
2003-02-01 6:13 ` Joel Brobecker
2003-02-01 6:40 ` Andrew Cagney
2003-02-02 5:36 ` Andrew Cagney
2003-02-01 17:33 Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E3B0633.7040502@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox