Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Subject: [patch] Set bfd field in target_section
Date: Tue, 28 Jul 2009 14:46:00 -0000	[thread overview]
Message-ID: <h4n1ui$nt3$1@ger.gmane.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

Hello,

I believe this is related to Pedro's patch from 03-Jun-09. I 
didn't see where we set target_section.bfd field - maybe I 
am overlooking something, but in bfd-target, in function 
target_bfd_xclose we will call bfd_close 
(table->sections->bfd); bfd_close doesn't like NULL argument.

Am I missing something, or is this (the patch) missing?

Patch attached.

Thanks,

-- 
Aleksandar Ristovski
QNX Software Systems

ChangeLog:

* exec.c (build_section_table): Setup section_table bfd field.

[-- Attachment #2: exec_c-20090728.diff --]
[-- Type: text/x-patch, Size: 641 bytes --]

Index: gdb/exec.c
===================================================================
RCS file: /cvs/src/src/gdb/exec.c,v
retrieving revision 1.90
diff -u -p -r1.90 exec.c
--- gdb/exec.c	2 Jul 2009 17:21:06 -0000	1.90
+++ gdb/exec.c	28 Jul 2009 14:21:09 -0000
@@ -441,6 +441,7 @@ build_section_table (struct bfd *some_bf
   bfd_map_over_sections (some_bfd, add_to_section_table, (char *) end);
   if (*end > *start + count)
     internal_error (__FILE__, __LINE__, _("failed internal consistency check"));
+  (*start)->bfd = (*end)->bfd = some_bfd;
   /* We could realloc the table, but it probably loses for most files.  */
   return 0;
 }

             reply	other threads:[~2009-07-28 14:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28 14:46 Aleksandar Ristovski [this message]
2009-07-28 14:51 ` Pedro Alves
2009-07-28 14:59   ` Pedro Alves
2009-07-28 15:06   ` Aleksandar Ristovski
2009-07-28 16:22     ` Pedro Alves
2009-07-28 16:37       ` Aleksandar Ristovski
2009-07-28 16:37         ` Pedro Alves
2009-07-28 21:48           ` Aleksandar Ristovski
2009-08-08 16:54             ` Pedro Alves
2009-07-28 15:16   ` Pedro Alves
2009-07-28 15:57     ` Aleksandar Ristovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='h4n1ui$nt3$1@ger.gmane.org' \
    --to=aristovski@qnx.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox