From: Aleksandar Ristovski <aristovski@qnx.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Set bfd field in target_section
Date: Tue, 28 Jul 2009 15:06:00 -0000 [thread overview]
Message-ID: <4A6F0F05.1060705@qnx.com> (raw)
In-Reply-To: <200907281534.41605.pedro@codesourcery.com>
Pedro Alves wrote:
> On Tuesday 28 July 2009 15:28:33, Aleksandar Ristovski wrote:
>> Hello,
>>
>> I believe this is related to Pedro's patch from 03-Jun-09. I
>> didn't see where we set target_section.bfd field - maybe I
>> am overlooking something, but in bfd-target, in function
>> target_bfd_xclose we will call bfd_close
>> (table->sections->bfd); bfd_close doesn't like NULL argument.
>>
>> Am I missing something, or is this (the patch) missing?
>
> Doesn't add_to_section_table set the bfd in each new
> target section?
Indeed it does. However, the problem is if we don't find any
sections in a bfd, it will exit and will leave bfd field 0.
I get this situation at the moment because I broke my
xfer_partial, but I think it could happen in general?
---
Aleksandar
next prev parent reply other threads:[~2009-07-28 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 14:46 Aleksandar Ristovski
2009-07-28 14:51 ` Pedro Alves
2009-07-28 14:59 ` Pedro Alves
2009-07-28 15:06 ` Aleksandar Ristovski [this message]
2009-07-28 16:22 ` Pedro Alves
2009-07-28 16:37 ` Aleksandar Ristovski
2009-07-28 16:37 ` Pedro Alves
2009-07-28 21:48 ` Aleksandar Ristovski
2009-08-08 16:54 ` Pedro Alves
2009-07-28 15:16 ` Pedro Alves
2009-07-28 15:57 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A6F0F05.1060705@qnx.com \
--to=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox