Re: [PATCH 2/2] gdb/dwarf: rename low_set variable in dwarf2_ranges_read

[Tom de Vries <tdevries@suse.de>]

On 3/12/26 5:32 PM, simon.marchi@polymtl.ca wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> Rename low_set to low_high_set, to reflect what it really means.
> 
> Also, change some manual min/max so use std::min/std::max, I think it
> makes the intent clearer.
> 

Hi,

LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>

Thanks,
- Tom

> Change-Id: I9ca81be915962e704becabe78c39b95e0abf561b
> ---
>   gdb/dwarf2/read.c | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
> index 5e310afc3f92..495b519faed4 100644
> --- a/gdb/dwarf2/read.c
> +++ b/gdb/dwarf2/read.c
> @@ -8717,7 +8717,7 @@ dwarf2_ranges_read (unsigned offset, unrelocated_addr *low_return,
>   		    unrelocated_addr *high_return, struct dwarf2_cu *cu,
>   		    addrmap_mutable *map, void *datum, dwarf_tag tag)
>   {
> -  bool low_set = false;
> +  bool low_high_set = false;
>     unrelocated_addr low = {};
>     unrelocated_addr high = {};
>     bool retval = dwarf2_ranges_process (offset, cu, tag,
> @@ -8735,29 +8735,26 @@ dwarf2_ranges_read (unsigned offset, unrelocated_addr *low_return,
>   	 segment of consecutive addresses.  We should have a
>   	 data structure for discontiguous block ranges
>   	 instead.  */
> -      if (!low_set)
> +      if (!low_high_set)
>   	{
>   	  low = range_beginning;
>   	  high = range_end;
> -	  low_set = true;
> +	  low_high_set = true;
>   	}
>         else
>   	{
> -	  if (range_beginning < low)
> -	    low = range_beginning;
> -
> -	  if (range_end > high)
> -	    high = range_end;
> +	  low = std::min (low, range_beginning);
> +	  high = std::max (high, range_end);
>   	}
>       });
>   
>     if (!retval)
>       return false;
>   
> -  if (!low_set)
> +  if (!low_high_set)
>       {
>         /* If the first entry is an end-of-list marker, the range
> -       describes an empty scope, i.e. no instructions.  */
> +	 describes an empty scope, i.e. no instructions.  */
>         return false;
>       }
>