From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SWqkEjDvsmnVMyYAWB0awg (envelope-from ) for ; Thu, 12 Mar 2026 12:52:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uk1vm3Xa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rKFfEadY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=x4dyB00m; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=piSZj4Pn; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4526C1E0DD; Thu, 12 Mar 2026 12:52:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C3D31E089 for ; Thu, 12 Mar 2026 12:51:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 072734BBC092 for ; Thu, 12 Mar 2026 16:51:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 072734BBC092 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uk1vm3Xa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=rKFfEadY; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=x4dyB00m; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=piSZj4Pn Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 2856A4BA23D0 for ; Thu, 12 Mar 2026 16:51:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2856A4BA23D0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2856A4BA23D0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773334291; cv=none; b=ZK+R04Tv4riGLzaq+FYaUlg6UubQJVWgRuV2K4l6rhaIB03gv+FHnp50QZKBq4dj03pnXTEyOnQILOfNdsomqaDOlI1uRxrEumfmTxKdlWQB6WHqdVSVCkhqULAAq3STftALSOoMsTOz247uV1v0AdbpIyOnTCsrQ/t2Sl5GfzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773334291; c=relaxed/simple; bh=goAgeTv9BRKnddyrbw60/w9GntkLcNZLen2yf78b91Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=C7+JaFokA36eMGoQSL6zLDHrjJo8J+2lsdCtj6uUG/voC+yJq6raB+JBSlMh/eMUyz3Xdw1LDXbdV0IVHBl4N4wLjJ06eHKc2YUTeWHYIsFpqZKAnwsYgd7v4oY7ogavfNkux3nKR3nRZQR+4ifrUve70ZHlWOq8F0WvOQgwfmg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2856A4BA23D0 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EFE1A5BCCD; Thu, 12 Mar 2026 16:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773334290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7US9bYXIBcNNvedJlyVLCfNAASUc6FZMW9hylrpVxA=; b=uk1vm3Xa0UjIOe8nGH1amZN8oWQjKtfaxw/WHETYiDNI6b5E0bJ/+XG2v1ogpmdMvuP74h YWJnCPmDfXYv7Oyl0I1o9+a93TRZRJCfuAjePfYRyZhe4N3AFs78akDrIquNb5TZ8NBMIi tTsxouGjxWYikH1q4+K1+2KRdYxmZh8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773334290; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7US9bYXIBcNNvedJlyVLCfNAASUc6FZMW9hylrpVxA=; b=rKFfEadYSGHS+uHwvKnMNLtKRkJy2tU5hoDNHweBliyR1j5zhCSz5JC2+gIbEvgzqJXiUE dWBC6x2DsdaN0iDg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=x4dyB00m; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=piSZj4Pn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773334289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7US9bYXIBcNNvedJlyVLCfNAASUc6FZMW9hylrpVxA=; b=x4dyB00mKBj8GMKHX6+5F9jqQmVMS4OgpeMRiWHhTtJbvUCEOFuSLSQer7dFe3wY0ffqqf Zuo+fcxt2aYnqMzQGRHGXF+xaqbiHwzZ+czVshah/tb/ICl7mkoccxm5DAL5IxtBNrqW8m q/DvR7OCH3jkUNcgK/mbFw+dKSgqNT4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773334289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z7US9bYXIBcNNvedJlyVLCfNAASUc6FZMW9hylrpVxA=; b=piSZj4Pncv0ndX1qKf7ieQubaxIfyc1t3S5MQ++2j21Mi38qQE9tTIIsTRKUMMvl9S9jn5 Xq+OFmQjwk7lHDDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D1F1A40085; Thu, 12 Mar 2026 16:51:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id m+DPMRHvsmm4DAAAD6G6ig (envelope-from ); Thu, 12 Mar 2026 16:51:29 +0000 Message-ID: Date: Thu, 12 Mar 2026 17:51:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] gdb/dwarf: rename low_set variable in dwarf2_ranges_read To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org References: <20260312163213.2650909-1-simon.marchi@polymtl.ca> <20260312163213.2650909-2-simon.marchi@polymtl.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260312163213.2650909-2-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Queue-Id: EFE1A5BCCD X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/12/26 5:32 PM, simon.marchi@polymtl.ca wrote: > From: Simon Marchi > > Rename low_set to low_high_set, to reflect what it really means. > > Also, change some manual min/max so use std::min/std::max, I think it > makes the intent clearer. > Hi, LGTM. Approved-By: Tom de Vries Thanks, - Tom > Change-Id: I9ca81be915962e704becabe78c39b95e0abf561b > --- > gdb/dwarf2/read.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 5e310afc3f92..495b519faed4 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -8717,7 +8717,7 @@ dwarf2_ranges_read (unsigned offset, unrelocated_addr *low_return, > unrelocated_addr *high_return, struct dwarf2_cu *cu, > addrmap_mutable *map, void *datum, dwarf_tag tag) > { > - bool low_set = false; > + bool low_high_set = false; > unrelocated_addr low = {}; > unrelocated_addr high = {}; > bool retval = dwarf2_ranges_process (offset, cu, tag, > @@ -8735,29 +8735,26 @@ dwarf2_ranges_read (unsigned offset, unrelocated_addr *low_return, > segment of consecutive addresses. We should have a > data structure for discontiguous block ranges > instead. */ > - if (!low_set) > + if (!low_high_set) > { > low = range_beginning; > high = range_end; > - low_set = true; > + low_high_set = true; > } > else > { > - if (range_beginning < low) > - low = range_beginning; > - > - if (range_end > high) > - high = range_end; > + low = std::min (low, range_beginning); > + high = std::max (high, range_end); > } > }); > > if (!retval) > return false; > > - if (!low_set) > + if (!low_high_set) > { > /* If the first entry is an end-of-list marker, the range > - describes an empty scope, i.e. no instructions. */ > + describes an empty scope, i.e. no instructions. */ > return false; > } >