From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] gdb/dwarf: don't pass lowpc/highpc to dwarf2_ranges_read in cooked_indexer::scan_attributes
Date: Sat, 14 Mar 2026 13:35:19 -0400 [thread overview]
Message-ID: <071b41c2-1821-4e88-aa6a-44ea63a35da7@polymtl.ca> (raw)
In-Reply-To: <a777baec-fe8f-45b8-91a1-d9f4610e06fb@suse.de>
On 2026-03-12 12:45, Tom de Vries wrote:
> On 3/12/26 5:32 PM, simon.marchi@polymtl.ca wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>>
>> It's not necessary to pass pointers to those variables
>> (dwarf2_ranges_read checks then for nullptr), and they are not used.
>
> Did you mean "as they are not used"?
It's not super clear, but I mean:
- dwarf2_ranges_read supports passing nullptr for those parameters
- scan_attributes doesn't really need the values
Since both these statements are true, we can switch to passing nullptr.
>
> Anyway, LGTM.
>
> Approved-By: Tom de Vries <tdevries@suse.de>
Thanks, will push.
Simon
prev parent reply other threads:[~2026-03-14 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 16:32 simon.marchi
2026-03-12 16:32 ` [PATCH 2/2] gdb/dwarf: rename low_set variable in dwarf2_ranges_read simon.marchi
2026-03-12 16:51 ` Tom de Vries
2026-03-12 16:45 ` [PATCH 1/2] gdb/dwarf: don't pass lowpc/highpc to dwarf2_ranges_read in cooked_indexer::scan_attributes Tom de Vries
2026-03-14 17:35 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=071b41c2-1821-4e88-aa6a-44ea63a35da7@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox