From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Pni/JnictWleXykAWB0awg (envelope-from ) for ; Sat, 14 Mar 2026 13:35:52 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=j+d2ee2q; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7DF161E089; Sat, 14 Mar 2026 13:35:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1FD1B1E089 for ; Sat, 14 Mar 2026 13:35:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 398FA4C31876 for ; Sat, 14 Mar 2026 17:35:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 398FA4C31876 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=j+d2ee2q Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 2D04D4B358B3 for ; Sat, 14 Mar 2026 17:35:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D04D4B358B3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D04D4B358B3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773509726; cv=none; b=FTmZ4UsNsfJaS/t0HVuC63gVGMvv3yeTF5lDaa4PJH6V/6alj+VFYiDKiBRiCNQfyAGjEWWXfD9fPKm0Q/m826zsgu0vG1W00qezD3CHvVe5zLIPHVld2LcUKzl/HVevdvYkIH/XlfFyzr1T4pblfbwnPq93M1rAKmxYVcijKf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773509726; c=relaxed/simple; bh=cgxGCDOX/6pLKQ5jJf96eIxrlrzDbD6fX8Ua983BPIM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=m6D2ptmDjf8wb/jsa8RiMrTKIp8auu2YrdHoJQ5iEIYVOoJaAzpw8eujLEVNO+j5rmitoY0jZBJ4Kdy556IpBh7qDaVrzaJwKDcVEv2L3NkPjOEYYp9pIyRckRasNVNVRlKs09Y7hq+nYRynwJH6dNOZU7Tg0F5A+nF1jVfAiZQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2D04D4B358B3 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 62EHZKwk123870 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 14 Mar 2026 13:35:24 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 62EHZKwk123870 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1773509725; bh=V35KKeZvKfvZKJ/oWMziEEbHb4Cysiohgp0e1rarQio=; h=Date:Subject:To:From:In-Reply-To:From; b=j+d2ee2qGgADmSGvzlcro3VpTTb2Hb6cXw3GEogqo8PEN+6QnAL4l/RFiKIQdkXDl kVQ5avq4y/21Q+r9VxNGL5nfWoqT+L8M7bg4cznKPq5+UwNSPNMWNoE53cYeXcXNfZ Yqx4L9p/QufLihj1oRjhAblPjMaLtWotyr7TCvngaS2oa2Wx/rL0oZwSjcrkPyTzy5 8gAs4J2wGZRG/U6YzFG223ytnRxtgaYJPhI+l1CIBaXSPV+aYse/Esz3ST04nYIYTh D7BhzqV7XbjkY9WWChKtplKZmnpU4T1+9TuNzTn0FdKEjAsudTtxQFJhMnK1Deyae1 2MWjlcZH58f2Q== Received: by simark.ca (Postfix) id 15B0F1E089; Sat, 14 Mar 2026 13:35:19 -0400 (EDT) Message-ID: <071b41c2-1821-4e88-aa6a-44ea63a35da7@polymtl.ca> Date: Sat, 14 Mar 2026 13:35:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/dwarf: don't pass lowpc/highpc to dwarf2_ranges_read in cooked_indexer::scan_attributes To: Tom de Vries , gdb-patches@sourceware.org References: <20260312163213.2650909-1-simon.marchi@polymtl.ca> Content-Language: en-US From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 14 Mar 2026 17:35:20 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-03-12 12:45, Tom de Vries wrote: > On 3/12/26 5:32 PM, simon.marchi@polymtl.ca wrote: >> From: Simon Marchi >> >> It's not necessary to pass pointers to those variables >> (dwarf2_ranges_read checks then for nullptr), and they are not used. > > Did you mean "as they are not used"? It's not super clear, but I mean: - dwarf2_ranges_read supports passing nullptr for those parameters - scan_attributes doesn't really need the values Since both these statements are true, we can switch to passing nullptr. > > Anyway, LGTM. > > Approved-By: Tom de Vries Thanks, will push. Simon