Re: [PATCH 1/2] gdb/dwarf: don't pass lowpc/highpc to dwarf2_ranges_read in cooked_indexer::scan_attributes

[Tom de Vries <tdevries@suse.de>]

On 3/12/26 5:32 PM, simon.marchi@polymtl.ca wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> It's not necessary to pass pointers to those variables
> (dwarf2_ranges_read checks then for nullptr), and they are not used.

Did you mean "as they are not used"?

Anyway, LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>

Thanks,
- Tom

> Remove them.
> 
> Change-Id: Id5462d481f209e9546380f52ddeea2eea811f5f3
> ---
>   gdb/dwarf2/cooked-indexer.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/dwarf2/cooked-indexer.c b/gdb/dwarf2/cooked-indexer.c
> index 40f62de80eb4..1848b92e2cab 100644
> --- a/gdb/dwarf2/cooked-indexer.c
> +++ b/gdb/dwarf2/cooked-indexer.c
> @@ -275,8 +275,8 @@ cooked_indexer::scan_attributes (dwarf2_per_cu *scanning_per_cu,
>   		 want to add this value.  */
>   	      ranges_offset += reader->cu ()->gnu_ranges_base;
>   
> -	      unrelocated_addr lowpc, highpc;
> -	      dwarf2_ranges_read (ranges_offset, &lowpc, &highpc, reader->cu (),
> +	      dwarf2_ranges_read (ranges_offset, nullptr, nullptr,
> +				  reader->cu (),
>   				  m_index_storage->get_addrmap (),
>   				  scanning_per_cu, abbrev->tag);
>   	    }
> 
> base-commit: 1fa846a3d49aa9025359c749965c64e1997d5a25