From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ibiwJ+7tsmnAMiYAWB0awg (envelope-from ) for ; Thu, 12 Mar 2026 12:46:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mdNSR0i2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8NB/PEMQ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mdNSR0i2; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8NB/PEMQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9BE141E0DD; Thu, 12 Mar 2026 12:46:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 18BD91E089 for ; Thu, 12 Mar 2026 12:46:38 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 80F844BB3BB8 for ; Thu, 12 Mar 2026 16:46:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 80F844BB3BB8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mdNSR0i2; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8NB/PEMQ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mdNSR0i2; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=8NB/PEMQ Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id BF0A04BA23D0 for ; Thu, 12 Mar 2026 16:45:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF0A04BA23D0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BF0A04BA23D0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773333958; cv=none; b=OVf4X3/2kLqV0+P5l0jfDofre9M4nPMlInRK/YbD92SA/ovj63IPh03EL5VJdQONkwJKk1UK1VBoXEanGTFM8DWrFbWgKFy3fZkQMFMTQBI1dU4cWuMugGpbLMYlgET6WUBvoxi0Nm97/BD60YGv19uwxZI3xSTot48MVBniKLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773333958; c=relaxed/simple; bh=sTLrQ0LoFb6TYx/A26Ifh2hgu/p0C6QpyzbR1avSYQs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=HM3P/d9lAPYF5JX/tnBSN/pAi4hxjFeILVR4ezujBBhBUMAnDYBx2VMDkq8XLqg5p/gwqflpZlUZ2iCLkS5xHKHVH4lsKoKswlucmVwmHcMnhzyNJoczl3nZcXEi+oAJYoA3UBXsjTmYxBekXHwWtxQ2Wxk8BobolKAwCccDtGs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF0A04BA23D0 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3A72C4D644; Thu, 12 Mar 2026 16:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773333956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQf0AWRm0b1BMklYAKm3h6Wa1Yyykij4tAKX5WxGn48=; b=mdNSR0i23U7qt/q8D4aWJhAQTHDimpQhcsz2iCyY6qZ2xOdD8+/REzkoWYsC80sDGRoMq2 iGALYDsWgLLF8ULm4P8OQsj3uoy6GG1c7f3x6Ru0WRbrwuXux0FHrMHsOIqX8D0qGmJ+WY y6BIt2XVraNqbeamz2NdbBd/nC6k2Jk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773333956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQf0AWRm0b1BMklYAKm3h6Wa1Yyykij4tAKX5WxGn48=; b=8NB/PEMQPUiEP0p2d+KKBdaSfkr16aVxqYvgiRqAAnQKDHj5Rr1hCWIayEKi0cjEO7+wa0 E8DqahXA3f4yEaDA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773333956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQf0AWRm0b1BMklYAKm3h6Wa1Yyykij4tAKX5WxGn48=; b=mdNSR0i23U7qt/q8D4aWJhAQTHDimpQhcsz2iCyY6qZ2xOdD8+/REzkoWYsC80sDGRoMq2 iGALYDsWgLLF8ULm4P8OQsj3uoy6GG1c7f3x6Ru0WRbrwuXux0FHrMHsOIqX8D0qGmJ+WY y6BIt2XVraNqbeamz2NdbBd/nC6k2Jk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773333956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xQf0AWRm0b1BMklYAKm3h6Wa1Yyykij4tAKX5WxGn48=; b=8NB/PEMQPUiEP0p2d+KKBdaSfkr16aVxqYvgiRqAAnQKDHj5Rr1hCWIayEKi0cjEO7+wa0 E8DqahXA3f4yEaDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 242C440080; Thu, 12 Mar 2026 16:45:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id h02UB8Ttsmm/BwAAD6G6ig (envelope-from ); Thu, 12 Mar 2026 16:45:56 +0000 Message-ID: Date: Thu, 12 Mar 2026 17:45:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/dwarf: don't pass lowpc/highpc to dwarf2_ranges_read in cooked_indexer::scan_attributes To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org References: <20260312163213.2650909-1-simon.marchi@polymtl.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260312163213.2650909-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MID_RHS_MATCH_FROM(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/12/26 5:32 PM, simon.marchi@polymtl.ca wrote: > From: Simon Marchi > > It's not necessary to pass pointers to those variables > (dwarf2_ranges_read checks then for nullptr), and they are not used. Did you mean "as they are not used"? Anyway, LGTM. Approved-By: Tom de Vries Thanks, - Tom > Remove them. > > Change-Id: Id5462d481f209e9546380f52ddeea2eea811f5f3 > --- > gdb/dwarf2/cooked-indexer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/dwarf2/cooked-indexer.c b/gdb/dwarf2/cooked-indexer.c > index 40f62de80eb4..1848b92e2cab 100644 > --- a/gdb/dwarf2/cooked-indexer.c > +++ b/gdb/dwarf2/cooked-indexer.c > @@ -275,8 +275,8 @@ cooked_indexer::scan_attributes (dwarf2_per_cu *scanning_per_cu, > want to add this value. */ > ranges_offset += reader->cu ()->gnu_ranges_base; > > - unrelocated_addr lowpc, highpc; > - dwarf2_ranges_read (ranges_offset, &lowpc, &highpc, reader->cu (), > + dwarf2_ranges_read (ranges_offset, nullptr, nullptr, > + reader->cu (), > m_index_storage->get_addrmap (), > scanning_per_cu, abbrev->tag); > } > > base-commit: 1fa846a3d49aa9025359c749965c64e1997d5a25