* [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments
@ 2022-08-29 12:24 Enze Li via Gdb-patches
2022-08-29 15:48 ` Simon Marchi via Gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Enze Li via Gdb-patches @ 2022-08-29 12:24 UTC (permalink / raw)
To: gdb-patches; +Cc: enze.li
The print_one_detail_ranged_breakpoint has been renamed to
ranged_breakpoint::print_one_detail in this commit:
commit ec45bb676c9c69c30783bcf35ffdac8280f3b8bc
Date: Sat Jan 15 16:34:51 2022 -0700
Convert ranged breakpoints to vtable ops
So their comments should be updated as well.
---
gdb/breakpoint.c | 2 +-
gdb/breakpoint.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 8f0b19f8518..63feea9e9cd 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -9215,7 +9215,7 @@ ranged_breakpoint::print_one (bp_location **last_loc) const
if (opts.addressprint)
/* We don't print the address range here, it will be printed later
- by print_one_detail_ranged_breakpoint. */
+ by ranged_breakpoint::print_one_detail. */
uiout->field_skip ("addr");
annotate_field (5);
print_breakpoint_location (this, bl);
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index 93f30c9c13d..360fa760577 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -691,7 +691,7 @@ struct breakpoint
breakpoint description in "info breakpoints".
In the example below, the "address range" line was printed
- by print_one_detail_ranged_breakpoint.
+ by ranged_breakpoint::print_one_detail.
(gdb) info breakpoints
Num Type Disp Enb Address What
--
2.37.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments
2022-08-29 12:24 [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments Enze Li via Gdb-patches
@ 2022-08-29 15:48 ` Simon Marchi via Gdb-patches
2022-08-30 13:15 ` Enze Li via Gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi via Gdb-patches @ 2022-08-29 15:48 UTC (permalink / raw)
To: Enze Li, gdb-patches; +Cc: enze.li
On 2022-08-29 08:24, Enze Li via Gdb-patches wrote:
> The print_one_detail_ranged_breakpoint has been renamed to
> ranged_breakpoint::print_one_detail in this commit:
>
> commit ec45bb676c9c69c30783bcf35ffdac8280f3b8bc
> Date: Sat Jan 15 16:34:51 2022 -0700
>
> Convert ranged breakpoints to vtable ops
>
> So their comments should be updated as well.
> ---
> gdb/breakpoint.c | 2 +-
> gdb/breakpoint.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 8f0b19f8518..63feea9e9cd 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -9215,7 +9215,7 @@ ranged_breakpoint::print_one (bp_location **last_loc) const
>
> if (opts.addressprint)
> /* We don't print the address range here, it will be printed later
> - by print_one_detail_ranged_breakpoint. */
> + by ranged_breakpoint::print_one_detail. */
> uiout->field_skip ("addr");
> annotate_field (5);
> print_breakpoint_location (this, bl);
> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
> index 93f30c9c13d..360fa760577 100644
> --- a/gdb/breakpoint.h
> +++ b/gdb/breakpoint.h
> @@ -691,7 +691,7 @@ struct breakpoint
> breakpoint description in "info breakpoints".
>
> In the example below, the "address range" line was printed
> - by print_one_detail_ranged_breakpoint.
> + by ranged_breakpoint::print_one_detail.
>
> (gdb) info breakpoints
> Num Type Disp Enb Address What
Thanks, this is OK.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments
2022-08-29 15:48 ` Simon Marchi via Gdb-patches
@ 2022-08-30 13:15 ` Enze Li via Gdb-patches
0 siblings, 0 replies; 3+ messages in thread
From: Enze Li via Gdb-patches @ 2022-08-30 13:15 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches, enze.li
On Mon, Aug 29, 2022 at 11:48:25 AM -0400, Simon Marchi wrote:
> On 2022-08-29 08:24, Enze Li via Gdb-patches wrote:
>> The print_one_detail_ranged_breakpoint has been renamed to
>> ranged_breakpoint::print_one_detail in this commit:
>>
>> commit ec45bb676c9c69c30783bcf35ffdac8280f3b8bc
>> Date: Sat Jan 15 16:34:51 2022 -0700
>>
>> Convert ranged breakpoints to vtable ops
>>
>> So their comments should be updated as well.
>> ---
>> gdb/breakpoint.c | 2 +-
>> gdb/breakpoint.h | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
>> index 8f0b19f8518..63feea9e9cd 100644
>> --- a/gdb/breakpoint.c
>> +++ b/gdb/breakpoint.c
>> @@ -9215,7 +9215,7 @@ ranged_breakpoint::print_one (bp_location **last_loc) const
>>
>> if (opts.addressprint)
>> /* We don't print the address range here, it will be printed later
>> - by print_one_detail_ranged_breakpoint. */
>> + by ranged_breakpoint::print_one_detail. */
>> uiout->field_skip ("addr");
>> annotate_field (5);
>> print_breakpoint_location (this, bl);
>> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
>> index 93f30c9c13d..360fa760577 100644
>> --- a/gdb/breakpoint.h
>> +++ b/gdb/breakpoint.h
>> @@ -691,7 +691,7 @@ struct breakpoint
>> breakpoint description in "info breakpoints".
>>
>> In the example below, the "address range" line was printed
>> - by print_one_detail_ranged_breakpoint.
>> + by ranged_breakpoint::print_one_detail.
>>
>> (gdb) info breakpoints
>> Num Type Disp Enb Address What
>
> Thanks, this is OK.
>
> Simon
Thanks, Simon. Pushed.
Enze
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-30 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 12:24 [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments Enze Li via Gdb-patches
2022-08-29 15:48 ` Simon Marchi via Gdb-patches
2022-08-30 13:15 ` Enze Li via Gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox