From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iBwBCpwNDmPJ5C8AWB0awg (envelope-from ) for ; Tue, 30 Aug 2022 09:16:12 -0400 Received: by simark.ca (Postfix, from userid 112) id 2577B1E4A7; Tue, 30 Aug 2022 09:16:12 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=EOC7EF3Z; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7844E1E222 for ; Tue, 30 Aug 2022 09:16:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 73426385357A for ; Tue, 30 Aug 2022 13:16:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73426385357A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1661865368; bh=U7rzgroAxEieNf7bUDMQYV+r+oMP87SHyOgZSBAzXFE=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=EOC7EF3ZIIe3CDNwDiFvrzE1fR1eZ3yreZfYnjKCXSWgbXOxNVydIqwi6A0270Esy 8K/EuTQK8376FblCzpdgNNh++Dk+M74Mxh3260JGiMg+Zinga6K6QXBxVvUeFiJh6B vFwy+Wwo7yZnmiurd87A9gGqjv16Z78hl+lxhx48= Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01olkn2013.outbound.protection.outlook.com [40.92.98.13]) by sourceware.org (Postfix) with ESMTPS id 4B3A03857C72 for ; Tue, 30 Aug 2022 13:15:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4B3A03857C72 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYw8+BPQOcJaWFgEbzjDh1Km2ZY2HSDEZkPv2lj62RUfSuuXFo5XF3JJV1ClIIYuhQDFjewS5bk2CTpNjKzFg942IAiCsJG6uLUxp03AWqt8F3VxT75KZHS0AqsdyNnYSZ4omwIJDz3zT9v1AIVD5H9Fse6mzmUm4L+ZewuIVEkAUoUpq51WnJmwzHWMiTna9ta4t8qxcOJD3ANpE2GB0Uaj6Ov2elv/Hzkh6KjiK0IZbIyf5L02zmt0E80t5ZqChekb/6lBb4a2W2hvgzwDWQFvSaL9d/E5FkLhuLDy97Fwd6Cf6S/KaiNBNqU8M1ouPWRSPHTuLBfdqoXlRtAcyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U7rzgroAxEieNf7bUDMQYV+r+oMP87SHyOgZSBAzXFE=; b=C9iw9bW4gcsSiYidhFluukpmFtXYcDScZPynKpCBmyS1CfvFB45tHNRjEp0u5K+/OYEMI2RuHJaD6FUc/L4g8eEsVFmX9qFyUqZqpaaXzIkp8dsXYcbI+9UM3vQX5tRAqPqebv41jrCcGVKQ5aeuKFX+pzg/IFjdJGOh1lqad+/e2sQZ+x+k/ZG14ozkYqpz6w2UvgvzFEzRITHxgXz79J0Zc0Zd7OIyzxshzXNMhRtvNAsB6A0UVsvPqicjxBlPRI/0lPjRkBfYuvypQib8aLZTRLonAiosrp1JxY6M2qYI2w7s07vio9h99qXbRV2dU11lwuhqxoAMfWamS0TnnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) by TYAP286MB0588.JPNP286.PROD.OUTLOOK.COM (2603:1096:402:35::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Tue, 30 Aug 2022 13:15:15 +0000 Received: from OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172]) by OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM ([fe80::fd29:1fe3:fd34:4172%9]) with mapi id 15.20.5566.021; Tue, 30 Aug 2022 13:15:15 +0000 To: Simon Marchi Subject: Re: [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments References: Date: Tue, 30 Aug 2022 21:15:07 +0800 In-Reply-To: (Simon Marchi's message of "Mon, 29 Aug 2022 11:48:25 -0400") Message-ID: Content-Type: text/plain X-TMN: [IUzkKkyy1J/+tDhVoJGj2vKO3SrR3ixz] X-ClientProxiedBy: SG2PR04CA0193.apcprd04.prod.outlook.com (2603:1096:4:14::31) To OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:197::9) X-Microsoft-Original-Message-ID: <87v8q9q3dw.fsf@hotmail.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3a97cb3-5732-4359-0b7d-08da8a89ad29 X-MS-TrafficTypeDiagnostic: TYAP286MB0588:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fTGv5QoMXQfPFYsTs8Q8Isd0oMYZwvvU0/2yiAa3RGDHkEu+JA7OxhVODyzKx9PQFvaC2JXS/JW4hnMIqwZbvIFq0BuMEspV1ZTh1loK8Fgy/vn7TwMNT096XUFZVY4COwfjBI9TNZDYISf9r6FDVnDcPOW5qbQ8we99pr9e+DkL4fjbAzZwCw8VyTWgHRzDiG3VHPxelWm9uc6RamoWODKtedJv6xDp75V2fVJnJy4Fp6oTpYSWCs4UkxSbKxcRBB0fFCg4DHYjPAVGKpZdGiiRvRu/lyPqVZofiYTe3iry1bPFedClm+ML2nGw6QcLQLRgSw/ctMItC92tqF/5CfAGcxVKCZnvVXDM1Qha+neUuRq23BFBZQ3TiGSwc05bhjOfv3lU35fDgsmGA2heBhV12X1jysqgngn+BtbUxxp9Q/DHxds325guGM3q19I7mt/c8EFGJQCyvv2Q82ABTyOWIa/C0zMs56VqmmPK+StjQb8k0OheLhRz6Opygn8CZyDQ5tCikMywFbYAEG9VZjWs+rgqEVfSMW7ve5TE2gxjHbAWopWcJVHQ31MPWdl8sFwRARKHKcsTGyEH5c5UT6YKzhomRAd4uR1KMei+goIcXFgrKcosH0drjFo6syWiPr+PCSWG1ygTqIqd8sv4FBkWcwrZug20zW86R0qgDh41irW+MMPI1++6n/ui4ZgI X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qiwHZdy6JhofecUzcyIWxTuUooJSkzkdY6SzgFH0Ixu7A4Hhm1rdWU6j4ydE?= =?us-ascii?Q?C7o1MZhDGcG8+JpJrSFFov9J7LRb95MbKCv0pGQrRYz2UeifspiUrHCxAq52?= =?us-ascii?Q?Aeowguqe+FOexLRo2u0laPqvdzepkmuzBPQgMaJjhyVOI4AvkMzk1+LyePfp?= =?us-ascii?Q?Bmm111u8JAiC9J6zyZCqb/UCVZza78ktNfx2Z6ccSxYWs38x7ungDuQWqKQ+?= =?us-ascii?Q?JBiBCCMte6bvmV1HYbX/SOoDHK97C63MTKnni+80qJMiJqdIcO6OK1E2iqxM?= =?us-ascii?Q?cQxOPId3p+AkRQVAv2zHWdOVq04mEEg+rfY1ZFT3dRBgBcTahJUBusSqVf7U?= =?us-ascii?Q?CnGbQsrI9CaoALEcCNTdmfu6F6lkIkLc0yS/xP6/jm6xyHEKsqWdYWp4OJTZ?= =?us-ascii?Q?4qpdZeSoI9X2s4kLmvKoodR9bGIfVPqJraSBhFr1xzOde/x0va82QiIWNxAV?= =?us-ascii?Q?azKtPR/4Uob5CDxqEZOqNvwkKdCwdUgPrsWWpBisOoIU305qn5QddWbtr1AU?= =?us-ascii?Q?VPMACFVpwiCG3BFGWFLoudpSD+6UqGXfScZmhmngwRfGHOgYNQ3nBIbzETZi?= =?us-ascii?Q?cGYqKWwS5rVWFPHgAnVWjMOPXJ6PcBnlXQ4XxjkBrzKpQpr17PEPA8Oco8Xc?= =?us-ascii?Q?PPJlk6b/Kq7XFjr2JudrESJBbWIEPLFwYAyXQq8TrC9JMyNDU0zlY3tO0hte?= =?us-ascii?Q?GIk/Qv2jH/DcVIhDPbsPdqa/l5wPRvd5PqOj9IxPg+7DUKKYP02kTDp7CPnM?= =?us-ascii?Q?wXqFetsfBhjzQeDedUPaaFRUimAO5rTsPRtEpUMt/HKPIcGHjdR+9vrEFYl5?= =?us-ascii?Q?tpfzSDwWlaoyuPmOWRQV75jlUsEtpyxFkM+kuLECKwgUl2PN1XA5fwQYy5FF?= =?us-ascii?Q?hpLzjfSCmdJlcVhUkOD7JhNSn8qAS+zHoOC7XkchcbP7yIW9s3nqwoCORIR6?= =?us-ascii?Q?tllnSlOTnYuqEvQ2rCKc6sSBtZDgboL4r6OagfOKN9LQseRsyqvs3OutyJA4?= =?us-ascii?Q?kDO89bAWIvV9ufL0OuoRcTfz3yOVXbXxRSOO7sKrYX6E7Z9qEzfNj4sPCMNe?= =?us-ascii?Q?iZwQoPJiMdh+0NV24LiyhZafwbHV3WB3gQuZmX3c8ulsCtm0iYqczCsmn3vY?= =?us-ascii?Q?RR1/PIO+GhcABqw6SBwr+Y6kFBoVquCOnmQwLcpjUYdDarG9T04wKfN8XhHW?= =?us-ascii?Q?nIc/SVP1Crqha6Oih0ay85PcEpdB0zAlGdOhY93b+bh4W1P5NZrpEUn0Oy4T?= =?us-ascii?Q?hsQAUo7kvlSNF2sgR+keyqv271rkCb2ygAgqEUGaeA=3D=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: f3a97cb3-5732-4359-0b7d-08da8a89ad29 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 13:15:14.9303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAP286MB0588 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Enze Li via Gdb-patches Reply-To: Enze Li Cc: gdb-patches@sourceware.org, enze.li@gmx.com Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Mon, Aug 29, 2022 at 11:48:25 AM -0400, Simon Marchi wrote: > On 2022-08-29 08:24, Enze Li via Gdb-patches wrote: >> The print_one_detail_ranged_breakpoint has been renamed to >> ranged_breakpoint::print_one_detail in this commit: >> >> commit ec45bb676c9c69c30783bcf35ffdac8280f3b8bc >> Date: Sat Jan 15 16:34:51 2022 -0700 >> >> Convert ranged breakpoints to vtable ops >> >> So their comments should be updated as well. >> --- >> gdb/breakpoint.c | 2 +- >> gdb/breakpoint.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c >> index 8f0b19f8518..63feea9e9cd 100644 >> --- a/gdb/breakpoint.c >> +++ b/gdb/breakpoint.c >> @@ -9215,7 +9215,7 @@ ranged_breakpoint::print_one (bp_location **last_loc) const >> >> if (opts.addressprint) >> /* We don't print the address range here, it will be printed later >> - by print_one_detail_ranged_breakpoint. */ >> + by ranged_breakpoint::print_one_detail. */ >> uiout->field_skip ("addr"); >> annotate_field (5); >> print_breakpoint_location (this, bl); >> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h >> index 93f30c9c13d..360fa760577 100644 >> --- a/gdb/breakpoint.h >> +++ b/gdb/breakpoint.h >> @@ -691,7 +691,7 @@ struct breakpoint >> breakpoint description in "info breakpoints". >> >> In the example below, the "address range" line was printed >> - by print_one_detail_ranged_breakpoint. >> + by ranged_breakpoint::print_one_detail. >> >> (gdb) info breakpoints >> Num Type Disp Enb Address What > > Thanks, this is OK. > > Simon Thanks, Simon. Pushed. Enze