Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
To: Simon Marchi <simark@simark.ca>
Cc: gdb-patches@sourceware.org, enze.li@gmx.com
Subject: Re: [PATCH] gdb: update ranged_breakpoint::print_one_detail in comments
Date: Tue, 30 Aug 2022 21:15:07 +0800	[thread overview]
Message-ID: <OS3P286MB2152E125E3CECC69A6E7FF58F0799@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <faa8aeb1-5aa9-bc31-1834-c655bc5b2be9@simark.ca> (Simon Marchi's message of "Mon, 29 Aug 2022 11:48:25 -0400")

On Mon, Aug 29, 2022 at 11:48:25 AM -0400, Simon Marchi wrote:
> On 2022-08-29 08:24, Enze Li via Gdb-patches wrote:
>> The print_one_detail_ranged_breakpoint has been renamed to
>> ranged_breakpoint::print_one_detail in this commit:
>> 
>>   commit ec45bb676c9c69c30783bcf35ffdac8280f3b8bc
>>   Date:   Sat Jan 15 16:34:51 2022 -0700
>> 
>>     Convert ranged breakpoints to vtable ops
>> 
>> So their comments should be updated as well.
>> ---
>>  gdb/breakpoint.c | 2 +-
>>  gdb/breakpoint.h | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
>> index 8f0b19f8518..63feea9e9cd 100644
>> --- a/gdb/breakpoint.c
>> +++ b/gdb/breakpoint.c
>> @@ -9215,7 +9215,7 @@ ranged_breakpoint::print_one (bp_location **last_loc) const
>>  
>>    if (opts.addressprint)
>>      /* We don't print the address range here, it will be printed later
>> -       by print_one_detail_ranged_breakpoint.  */
>> +       by ranged_breakpoint::print_one_detail.  */
>>      uiout->field_skip ("addr");
>>    annotate_field (5);
>>    print_breakpoint_location (this, bl);
>> diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
>> index 93f30c9c13d..360fa760577 100644
>> --- a/gdb/breakpoint.h
>> +++ b/gdb/breakpoint.h
>> @@ -691,7 +691,7 @@ struct breakpoint
>>       breakpoint description in "info breakpoints".
>>  
>>       In the example below, the "address range" line was printed
>> -     by print_one_detail_ranged_breakpoint.
>> +     by ranged_breakpoint::print_one_detail.
>>  
>>       (gdb) info breakpoints
>>       Num     Type           Disp Enb Address    What
>
> Thanks, this is OK.
>
> Simon

Thanks, Simon.  Pushed.

Enze

      reply	other threads:[~2022-08-30 13:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 12:24 Enze Li via Gdb-patches
2022-08-29 15:48 ` Simon Marchi via Gdb-patches
2022-08-30 13:15   ` Enze Li via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS3P286MB2152E125E3CECC69A6E7FF58F0799@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
    --to=gdb-patches@sourceware.org \
    --cc=enze.li@gmx.com \
    --cc=enze.li@hotmail.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox