Re: [PATCH 1/2] gdb: Allow address space qualifier parsing in C++.

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

> This '@address_space_qualifier' is a bit of an undocumented and untested feature AFAIK. Even the avr tests for __flash don't test it.
> I did search the git history a bit, but couldn't really determine why it was added. Only that it was added years before the __flash patch was.
> But since it is there and since I need a language agnostic way to specify this, I plan to use it for a future target.
> 
> The only test I could currently write for this patch is something like:
> gdb_test "*(@somerandomqualifiername int *) 0x12345678" "Unknown address space specifier: \"somerandomqualifiername\""> 
> for a C++ program on any target. If you think that is valuable, I can easily add that.
> The target I want to use this for in the end won't be ready for upstream for a while unfortunately.

Hi Felix,

I think it would be valuable to have a test like this.  It's better
than nothing, and it's always good to check error cases to make sure GDB
doesn't crash on them.  I can imagine that this test could test with
both a C and C++ program to cover everything correctly (and maybe other
languages, but I don't know much about them, if that even applies to
them).

A while ago I added a simavr board file, to be able to run tests against
an AVR target.  simavr is easy to build and use (it may even be packaged
in distros, but I'd be tempted to use the latest available version).
All of this to say you could try to run and improve the flash qualifier
test for AVR (or write a new test).

There's just one thing, avr-gcc/avr-g++ seem to produce stabs by
default, it's not really useful to test with stabs nowadays.  I had a
patch to make that board use dwarf by default (see below), but I never
got around to try it properly and post it.  I'll try to do it soon (but
you can apply it locally in the mean time).

Simon


From d1215e56aad6f9fc02f2cb2318ea522b32fd4f79 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@efficios.com>
Date: Sun, 21 Jun 2020 11:25:12 -0400
Subject: [PATCH] gdb/testsuite: use -gdwarf-4 in simavr board

Change-Id: I70e471fad3a79ab1d79d13dda8436bb9eb666e0a
---
 gdb/testsuite/boards/simavr.exp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/testsuite/boards/simavr.exp b/gdb/testsuite/boards/simavr.exp
index c4f278ccb12e..35885ef78c27 100644
--- a/gdb/testsuite/boards/simavr.exp
+++ b/gdb/testsuite/boards/simavr.exp
@@ -43,6 +43,7 @@ set_board_info c++compiler avr-g++
 
 set_board_info cflags "-mmcu=${simavr_mcu}"
 set_board_info ldflags "-mmcu=${simavr_mcu}"
+set_board_info debug_flags "-gdwarf-4"
 
 set_board_info use_gdb_stub 1
 set_board_info gdb_protocol "remote"
-- 
2.30.1