From: "Willgerodt, Felix via Gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>,
Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
Subject: RE: [PATCH 2/2] gdb: Fix reduce/reduce conflicts for qualifier_seq_noopt in the C parser.
Date: Fri, 2 Apr 2021 12:33:40 +0000 [thread overview]
Message-ID: <dab7d374b11341658ee04bb241e36ff9@intel.com> (raw)
In-Reply-To: <874kgpooib.fsf@tromey.com>
>Felix> Note that how the binding of this qualifier is interpreted and
>Felix> resolved for an address/pointer is target specific. Hence only
>Felix> the prepended qualifier works for AVR, even if it seems
>Felix> syntactically incorrect. I won't change this for AVR, as I am not familiar with that target.
Tom>Probably we should follow whatever GCC does here.
We should, but we don't for AVR (the binding in GDBs internal type representation is correct). I checked with avr-gcc 9.2.0 and 'target sim avr', hence this paragraph.
But I am not familiar enough with AVR to fix this, as it would require changes to the avr-tdep file and the address tagging/translation logic in there.
Thanks, I will push this together with the first patch once the testing question is resolved there.
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2021-04-02 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 14:26 [PATCH 0/2] Expression parser fixes for address space qualifiers Felix Willgerodt via Gdb-patches
2021-03-26 14:26 ` [PATCH 1/2] gdb: Allow address space qualifier parsing in C++ Felix Willgerodt via Gdb-patches
2021-04-01 18:16 ` Tom Tromey
2021-04-02 12:33 ` Willgerodt, Felix via Gdb-patches
2021-04-02 12:47 ` Luis Machado via Gdb-patches
2021-04-02 16:48 ` Simon Marchi via Gdb-patches
2021-04-02 16:51 ` Simon Marchi via Gdb-patches
2021-04-05 2:32 ` Simon Marchi via Gdb-patches
2021-04-06 9:30 ` Willgerodt, Felix via Gdb-patches
2021-03-26 14:26 ` [PATCH 2/2] gdb: Fix reduce/reduce conflicts for qualifier_seq_noopt in the C parser Felix Willgerodt via Gdb-patches
2021-04-01 18:20 ` Tom Tromey
2021-04-02 12:33 ` Willgerodt, Felix via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dab7d374b11341658ee04bb241e36ff9@intel.com \
--to=gdb-patches@sourceware.org \
--cc=felix.willgerodt@intel.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox