Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Willgerodt, Felix via Gdb-patches" <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>,
	Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/2] gdb: Allow address space qualifier parsing in C++.
Date: Fri, 2 Apr 2021 12:33:05 +0000	[thread overview]
Message-ID: <f8af73b51a4e43ed98a00d807e078ff0@intel.com> (raw)
In-Reply-To: <878s61ooph.fsf@tromey.com>

> Do we have or want a test for this?
>
> Tom

This '@address_space_qualifier' is a bit of an undocumented and untested feature AFAIK. Even the avr tests for __flash don't test it.
I did search the git history a bit, but couldn't really determine why it was added. Only that it was added years before the __flash patch was.
But since it is there and since I need a language agnostic way to specify this, I plan to use it for a future target.

The only test I could currently write for this patch is something like:
gdb_test "*(@somerandomqualifiername int *) 0x12345678" "Unknown address space specifier: \"somerandomqualifiername\""

for a C++ program on any target. If you think that is valuable, I can easily add that.
The target I want to use this for in the end won't be ready for upstream for a while unfortunately.

Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2021-04-02 12:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26 14:26 [PATCH 0/2] Expression parser fixes for address space qualifiers Felix Willgerodt via Gdb-patches
2021-03-26 14:26 ` [PATCH 1/2] gdb: Allow address space qualifier parsing in C++ Felix Willgerodt via Gdb-patches
2021-04-01 18:16   ` Tom Tromey
2021-04-02 12:33     ` Willgerodt, Felix via Gdb-patches [this message]
2021-04-02 12:47       ` Luis Machado via Gdb-patches
2021-04-02 16:48       ` Simon Marchi via Gdb-patches
2021-04-02 16:51         ` Simon Marchi via Gdb-patches
2021-04-05  2:32           ` Simon Marchi via Gdb-patches
2021-04-06  9:30         ` Willgerodt, Felix via Gdb-patches
2021-03-26 14:26 ` [PATCH 2/2] gdb: Fix reduce/reduce conflicts for qualifier_seq_noopt in the C parser Felix Willgerodt via Gdb-patches
2021-04-01 18:20   ` Tom Tromey
2021-04-02 12:33     ` Willgerodt, Felix via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8af73b51a4e43ed98a00d807e078ff0@intel.com \
    --to=gdb-patches@sourceware.org \
    --cc=felix.willgerodt@intel.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox